1280371 - move ELEMENT_STYLE out of devtools/server/actors/styles.js

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P1)

Description

[Tom Tromey :tromey]

The inspector does this in a few spots:

const {ELEMENT_STYLE} = require("devtools/server/actors/styles");

However we shouldn't include code from server in content.
This constant should probably move to the front; or somehow
be shared in devtools/shared/specs/styles.js

Comment 1

[Tom Tromey :tromey]

Attachment: Bug 1280371 - move ELEMENT_STYLE to devtools/shared/specs/styles;

Review commit: https://reviewboard.mozilla.org/r/59494/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59494/

Comment 2

[Tom Tromey :tromey]

Comment on attachment 8763190 [details]
Bug 1280371 - move ELEMENT_STYLE to devtools/shared/specs/styles;

Patrick is out sick, so redirecting review.

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 8763190 [details]
Bug 1280371 - move ELEMENT_STYLE to devtools/shared/specs/styles;

https://reviewboard.mozilla.org/r/59494/#review56782

Comment 4

[Tom Tromey :tromey]

Comment on attachment 8763190 [details]
Bug 1280371 - move ELEMENT_STYLE to devtools/shared/specs/styles;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59494/diff/1-2/

Comment 5

[Tom Tromey :tromey]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=47508abe9e75

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/798569199ac7
Move ELEMENT_STYLE to devtools/shared/specs/styles. r=bgrins

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/798569199ac7