[a11y] Make the bug summary a heading level 1

VERIFIED FIXED

Status

()

bugzilla.mozilla.org
User Interface: Modal
P1
enhancement
VERIFIED FIXED
a year ago
10 months ago

People

(Reporter: MarcoZ, Assigned: kohei)

Tracking

({access})

Production
access

Details

Attachments

(1 attachment)

(Reporter)

Description

a year ago
For screen reader users to more easily find it, the div with ID field-value-short_desc should be turned into an <h1> element. Or, if that is for some reason not really feasible, atleast give the div a role of "heading" and an aria-level of "1".

Having this div turned into an h1 will probably also help with indexing by search engines.
Severity: normal → enhancement
Priority: -- → P1

Comment 1

10 months ago
We would like to fix this before we switch over to modal as default.
Blocks: 1150541
(Assignee)

Comment 2

10 months ago
Created attachment 8825140 [details] [diff] [review]
1280388.patch

This one is pretty easy. Patch attached.
Assignee: nobody → kohei.yoshino
Status: NEW → ASSIGNED

Updated

10 months ago
Attachment #8825140 - Flags: review?(dkl)

Comment 3

10 months ago
Comment on attachment 8825140 [details] [diff] [review]
1280388.patch

Review of attachment 8825140 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl
Attachment #8825140 - Flags: review?(dkl) → review+

Comment 4

10 months ago
To https://github.com/mozilla-bteam/bmo.git
   8e1d385..ccb3104  master -> master
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → FIXED

Comment 5

10 months ago
This change is live now.
(Reporter)

Comment 6

10 months ago
(In reply to David Lawrence [:dkl] from comment #5)
> This change is live now.

...and works great. :-)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.