1280460 - [IOS 10] Today Widget copied link is overlapped by the open tabs buttons

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect, P1)

Description

[Simon Basca [:SimonB]]

Attachment: IMG_0092.PNG

Build: 5.0b11
Device: Iphone 6 S (IOS 10)

Steps to reproduce:
1. Launch Firefox and go to google.com
2. Copy the link from the URL bar
3. Open Today Widget

Actual: 
- The copied link will be overlapped by the open new tab buttons in Today Widget.

Comment 1

[Simon Basca [:SimonB]]

Tested on:
Build: 5.1b3
Device: iPad mini 4
iOS: 10b6

The issue is not reproducible on the current build.

Comment 2

[Stephan Leroux [:sleroux]]

Verify on 10 beta 7

Comment 3

[Simon Basca [:SimonB]]

Tested on 5.1b3:

Device: iPad mini 4, iPhone 6 S
iOS: 10b7

The issue is not reproducible following the above STR.

Comment 4

[Robin Andersen [:tecgirl]]

Reopening as I'm seeing on today's master. iOS 10, iPhone 7.

Comment 5

[Robin Andersen [:tecgirl]]

Attachment: IMG_2366.PNG

Comment 6

[Catalin Suciu [:csuciu]]

Attachment: Screen Shot 2016-09-27 at 15.42.44.png

Similar issue on an iPad Air 2 running iOS 10.0.2/latest master (0484a51f)

Comment 7

[Robin Andersen [:tecgirl]]

Attachment: IMG_2505.PNG

FWIW, release shows a darker bg; not sure what we're doing differently.

Comment 8

[Farhan Patel [:farhan]]

Attachment: Pull Request

I've redone this using UIStackview now that we are ios9+. Let me know what you think!

Comment 9

[Brian Nicholson (:bnicholson)]

Comment on attachment 8799659 [details] [review]
Pull Request

LGTM with PR review comments addressed.

Comment 10

[Farhan Patel [:farhan]]

master https://github.com/mozilla-mobile/firefox-ios/commit/248b867fd6574030ec6c8155089986fb52cd21ab

I've redone the entire layout for the TodayWidget. I think I've been pretty careful to avoid any regressions but some double checking would be much appreciated. Make sure to try different screen sizes.

Comment 11

[Adrian Oniga]

Verified on iPhone 6, iOS 10.2.1, Firefox 8.0(1), buddybuild #1886