Turn on highlight for WebAssembly text format

RESOLVED FIXED in Firefox 50

Status

defect
RESOLVED FIXED
3 years ago
Last year

People

(Reporter: yury, Assigned: yury)

Tracking

unspecified
Firefox 50
Dependency tree / graph

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 years ago
Bug 1274618 landed to display text for WebAssembly code (improved in bug 1274618). It will be nice to add highlight to CodeMirror for this format. Grammar is currently can be found at https://github.com/mbebenita/was/blob/master/was_lexer.l
Assignee

Comment 2

3 years ago
James, I tentatively set you as a reviewer -- let me know if you cannot review the CodeMirror integration piece.
Assignee

Updated

3 years ago
Depends on: 1274618
Comment on attachment 8763108 [details]
Bug 1280471 - Turn on highlight for WebAssembly text format.

https://reviewboard.mozilla.org/r/59436/#review57266

Looks good to me!
Attachment #8763108 - Flags: review?(jlong) → review+
Assignee

Updated

3 years ago
Keywords: checkin-needed

Comment 4

3 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/87b183a92a93
Turn on highlight for WebAssembly text format. r=jlongster
Keywords: checkin-needed

Comment 5

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/87b183a92a93
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Assignee

Updated

3 years ago
See Also: → 1308510

Updated

Last year
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.