Turn on highlight for WebAssembly text format

RESOLVED FIXED in Firefox 50

Status

DevTools
Debugger
RESOLVED FIXED
2 years ago
a month ago

People

(Reporter: yury, Assigned: yury)

Tracking

unspecified
Firefox 50

Firefox Tracking Flags

(firefox50 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Bug 1274618 landed to display text for WebAssembly code (improved in bug 1274618). It will be nice to add highlight to CodeMirror for this format. Grammar is currently can be found at https://github.com/mbebenita/was/blob/master/was_lexer.l
(Assignee)

Comment 1

2 years ago
Created attachment 8763108 [details]
Bug 1280471 - Turn on highlight for WebAssembly text format.

Review commit: https://reviewboard.mozilla.org/r/59436/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59436/
Attachment #8763108 - Flags: review?(jlong)
(Assignee)

Comment 2

2 years ago
James, I tentatively set you as a reviewer -- let me know if you cannot review the CodeMirror integration piece.
(Assignee)

Updated

2 years ago
Depends on: 1274618
Comment on attachment 8763108 [details]
Bug 1280471 - Turn on highlight for WebAssembly text format.

https://reviewboard.mozilla.org/r/59436/#review57266

Looks good to me!
Attachment #8763108 - Flags: review?(jlong) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 4

2 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/87b183a92a93
Turn on highlight for WebAssembly text format. r=jlongster
Keywords: checkin-needed

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/87b183a92a93
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
(Assignee)

Updated

2 years ago
See Also: → bug 1308510

Updated

a month ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.