Closed Bug 1280471 Opened 5 years ago Closed 5 years ago

Turn on highlight for WebAssembly text format

Categories

(DevTools :: Debugger, defect)

defect
Not set
normal

Tracking

(firefox50 fixed)

RESOLVED FIXED
Firefox 50
Tracking Status
firefox50 --- fixed

People

(Reporter: yury, Assigned: yury)

References

Details

Attachments

(1 file)

Bug 1274618 landed to display text for WebAssembly code (improved in bug 1274618). It will be nice to add highlight to CodeMirror for this format. Grammar is currently can be found at https://github.com/mbebenita/was/blob/master/was_lexer.l
James, I tentatively set you as a reviewer -- let me know if you cannot review the CodeMirror integration piece.
Depends on: 1274618
Comment on attachment 8763108 [details]
Bug 1280471 - Turn on highlight for WebAssembly text format.

https://reviewboard.mozilla.org/r/59436/#review57266

Looks good to me!
Attachment #8763108 - Flags: review?(jlong) → review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/87b183a92a93
Turn on highlight for WebAssembly text format. r=jlongster
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/87b183a92a93
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
See Also: → 1308510
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.