1280525 - Search highlight (Ctrl + F) does not work properly when text is erased

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Willian Gustavo Veiga]

Attachment: error.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20160616030228

Steps to reproduce:

1 - Press Ctrl + F.
2 - Type a word present in the current web page.
3 - Erase the whole search criteria.


Actual results:

The search criteria (or part of it) continues highlighted. The gray overlay continues on the page.


Expected results:

The highlight and the overlay must not continue on the page.

Comment 1

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

[Tracking Requested - why for this release]: Regression

Comment 2

[Joseph Yeh [:joseph]]

Attachment: 0001-Bug-1280525-Search-highlight-Ctrl-F-does-not-work-pr.patch

Hi Mike,

I just made a simple patch for this bug. Any feedback is welcome :)

Thanks!

Comment 3

[Joseph Yeh [:joseph]]

Looks like duplicate with Bug 1280061, is it?

Comment 4

[Mike de Boer [:mikedeboer]]

Comment on attachment 8767862 [details] [diff] [review]
0001-Bug-1280525-Search-highlight-Ctrl-F-does-not-work-pr.patch

Review of attachment 8767862 [details] [diff] [review]:
-----------------------------------------------------------------

Good find :)

Comment 6

[Marcia Knous [:marcia]]

Feature has been backed out so not tracking these bugs for 50.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/eb47026cced7
Search highlight (Ctrl + F) does not work properly when text is erased. r=mdeboer

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/eb47026cced7