Disable macOS Sierra 10.12 Window Tabs

RESOLVED FIXED in Firefox 49

Status

()

Core
Widget: Cocoa
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Cam, Assigned: mstange)

Tracking

(Blocks: 1 bug)

49 Branch
mozilla50
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox47 wontfix, firefox48 wontfix, firefox49 fixed, firefox50 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:49.0) Gecko/20100101 Firefox/49.0
Build ID: 20160616004032

Steps to reproduce:

watched http://devstreaming.apple.com/videos/wwdc/2016/203x2w42att1kdzg1ce/203/hls_vod_mvp.m3u8


Actual results:

They mentioned (around ~16:29) that applications using appkit need to disable the new window tabs that are introduced in macOS 10.12 Sierra or else you'll windo up with two different tab sets fighting.


Expected results:

call allowsAutomaticWindowTabbing:false on NSWindow before creating any windows

Updated

2 years ago
Component: Untriaged → Widget: Cocoa
OS: Unspecified → Mac OS X
Product: Firefox → Core
Hardware: Unspecified → x86
(Assignee)

Updated

2 years ago
Blocks: 1283571
(Assignee)

Comment 1

2 years ago
Thank you for filing this bug.
(Assignee)

Comment 2

2 years ago
Created attachment 8766994 [details]
Bug 1280546 - Disable automatic NSWindow tabbing on 10.12.

Review commit: https://reviewboard.mozilla.org/r/61706/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61706/
Attachment #8766994 - Flags: review?(spohl.mozilla.bugs)
Attachment #8766994 - Flags: review?(spohl.mozilla.bugs) → review+

Comment 4

2 years ago
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6041ca217693
Disable automatic NSWindow tabbing on 10.12. r=spohl
(Assignee)

Updated

2 years ago
Assignee: nobody → mstange
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6041ca217693
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
No longer depends on: 1285532
(Assignee)

Updated

2 years ago
status-firefox47: --- → affected
status-firefox48: --- → affected
status-firefox49: --- → affected
(Assignee)

Comment 6

2 years ago
Comment on attachment 8766994 [details]
Bug 1280546 - Disable automatic NSWindow tabbing on 10.12.

Approval Request Comment
[Feature/regressing bug #]: macOS 10.12 Sierra
[User impact if declined]: The user may see two tab rows in their window - one provided by Firefox and one provided by the system. I haven't actually seen this happen, but it's a bit magic so maybe I just don't know how to trigger it.
[Describe test coverage new/current, TreeHerder]: none
[Risks and why]: extremely low
[String/UUID change made/needed]: none
Attachment #8766994 - Flags: approval-mozilla-aurora?
status-firefox47: affected → wontfix
status-firefox48: affected → wontfix
Comment on attachment 8766994 [details]
Bug 1280546 - Disable automatic NSWindow tabbing on 10.12.

Improve mac os x support on 10.12, taking it
Attachment #8766994 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 8

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/385b9ea08ff7
status-firefox49: affected → fixed
You need to log in before you can comment on or make changes to this bug.