1280546 - Disable macOS Sierra 10.12 Window Tabs

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Cam]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:49.0) Gecko/20100101 Firefox/49.0
Build ID: 20160616004032

Steps to reproduce:

watched http://devstreaming.apple.com/videos/wwdc/2016/203x2w42att1kdzg1ce/203/hls_vod_mvp.m3u8


Actual results:

They mentioned (around ~16:29) that applications using appkit need to disable the new window tabs that are introduced in macOS 10.12 Sierra or else you'll windo up with two different tab sets fighting.


Expected results:

call allowsAutomaticWindowTabbing:false on NSWindow before creating any windows

Comment 1

[Markus Stange [:mstange]]

Thank you for filing this bug.

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1280546 - Disable automatic NSWindow tabbing on 10.12.

Review commit: https://reviewboard.mozilla.org/r/61706/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61706/

Comment 3

[Stephen A Pohl [:spohl]]

Comment on attachment 8766994 [details]
Bug 1280546 - Disable automatic NSWindow tabbing on 10.12.

https://reviewboard.mozilla.org/r/61706/#review58572

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6041ca217693
Disable automatic NSWindow tabbing on 10.12. r=spohl

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6041ca217693

Comment 6

[Markus Stange [:mstange]]

Comment on attachment 8766994 [details]
Bug 1280546 - Disable automatic NSWindow tabbing on 10.12.

Approval Request Comment
[Feature/regressing bug #]: macOS 10.12 Sierra
[User impact if declined]: The user may see two tab rows in their window - one provided by Firefox and one provided by the system. I haven't actually seen this happen, but it's a bit magic so maybe I just don't know how to trigger it.
[Describe test coverage new/current, TreeHerder]: none
[Risks and why]: extremely low
[String/UUID change made/needed]: none

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8766994 [details]
Bug 1280546 - Disable automatic NSWindow tabbing on 10.12.

Improve mac os x support on 10.12, taking it

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/385b9ea08ff7