Closed Bug 1280576 Opened 8 years ago Closed 8 years ago

Get room owner detection & opening working again on Akita

Categories

(Hello (Loop) :: Client, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: standard8, Assigned: standard8)

References

Details

User Story

When a user opens their own link, they should:

- be presented with a different standalone display
- should have a button to click to open the room
-- the room should open in a new window.
- if the room is already open, it should switch to the open window, and display a message on the opened link

Attachments

(1 file)

Currently if you open a link to your own room in Firefox, it fails due to not all the code having been hooked up following other Akita fixes.

This bug is to fix that and get it working again.
Rank: 19
Blocks: 1280810
Comment on attachment 8763266 [details] [review]
[loop] Standard8:own-room-fix > mozilla:akita

This gets the "own-room" case working again and gets the functional test for it working again.

Getting the other functional test working is split off to a different bug, as are various other outstanding issues.

The next bug(s) are probably going to contain a rename of a lot of the activeRoomStore related code (e.g. the store & the actions).
Attachment #8763266 - Flags: review?(edilee)
Attachment #8763266 - Flags: review?(dmose)
Attachment #8763266 - Flags: review?(dcritchley)
Attachment #8763266 - Flags: review?(b.mcb)
Blocks: 1281142
Attachment #8763266 - Flags: review?(edilee)
Attachment #8763266 - Flags: review?(dmose)
Attachment #8763266 - Flags: review?(b.mcb)
Attachment #8763266 - Flags: review?(dcritchley) → review+
https://github.com/mozilla/loop/commit/1e95c6a0abeee318921e832a63cdf5dc4bb77ae9
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: