1280606 - Dotted square cuts through the description of icons

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Bogdan Maris, Desktop Test Engineering]

Attachment: Screencast showing the issue

[Affected versions]:
- Firefox 48 beta 1
- latest Developer Edition 49.0a2
- latest Nightly 50.0a1

[Affected platforms]:
- Ubuntu 16.04 32-bit
- Windows 8.1 64-bit

[Unaffected platforms]:
- Mac OS X 10.10.5

[Steps to reproduce]:
1. Start Firefox
2. Enter Customization
3. Press Tab key
4. Click Forget tool (or any other that contains 'g', 'y' or 'p'.
5. Move 'New Non-e10s Window' to Additional Tools and Features and click it

[Expected result]:
- Dotted square is not overlapping the name of the Tools

[Actual result]:
- Dotted square is overlapping the name of the Tools

[Regression range]:
- This is not a regression range, this reproduces since accessibility support was added in bug 1116578

[Additional notes]:
- Gif attached showing the issue

Comment 1

[:Gijs (out for now; he/him)]

Jared, can we just change the outline-offset from -5px to nothing or -2px or whatever makes this work more reliably?

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1280606 - Dotted square cuts through the description of icons.

Review commit: https://reviewboard.mozilla.org/r/60592/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/60592/

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8765094 [details]
Bug 1280606 - Dotted square cuts through the description of icons.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/60592/diff/1-2/

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

We had the outline-offset for two reasons.

1) The placeholder in the panel uses the same outline-offset. It is probably fine for these to be different as they serve different purposes.

2) We needed the outline-offset because the top of the focusring was getting clipped in the palette. By adding some padding to the top of the palette, the focusring on the first row is no longer clipped.

I kept the outline-offset on the paletteitems in the toolbar because there is no text in the toolbar, and the top and bottom outline overlaps with the toolbar border making it harder to tell which item the focusring is around.

Comment 5

[:Gijs (out for now; he/him)]

Comment on attachment 8765094 [details]
Bug 1280606 - Dotted square cuts through the description of icons.

https://reviewboard.mozilla.org/r/60592/#review57834

Nice, thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e4d8f1de91a3
Dotted square cuts through the description of icons. r=Gijs

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e4d8f1de91a3

Comment 8

[Saheda Reza [:Antora]]

Reproduced this bug on Firefox nightly according to(2016-06-17 )

Fixing bug is verified on Latest Nightly--Build ID:( 20160711034039 ), User Agent: Mozilla/5.0 (Windows NT 10.0; rv:50.0) Gecko/20100101 Firefox/50.0

Tested OS--Windows10 32bit

Comment 9

[:Gijs (out for now; he/him)]

Should we uplift this?

Comment 10

[Nazir Ahmed Sabbir [:NaSb]]

I've managed this issue on this bug in Nightly 50.0a1 (2016-06-17) ; (Build ID: 20160617030217) from Linux.

This Bug is now verified as fixed on Latest Firefox Nightly 50.0a1 (2016-07-25)

Build ID: 20160725030248
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0
OS: Linux 4.4.0-31-generic ; Ubuntu 16.04 (64 Bit)

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

Sorry, I waited to long to respond to the uplift question and now it would mean uplifting to beta which I think is a "no". Clearing needinfo.