1280736 - service workers should report console service messages to debugger popup console

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect, P5)

Description

[Ben Kelly [:bkelly, not reviewing]]

If you debug a service worker script using about:debugging, you will get a new popup window showing the debugger and a console.  Currently service worker console reports do not show up in this console AFAICT.  We should adjust the ServiceWorkerManager::ReportToAllClients() method to include these debugger windows.

Comment 1

[Jan Keromnes [:janx]]

Brian or Eddy, didn't this work before? Is this a regression?

Comment 2

[Brian Grinstead [:bgrins]]

This never worked in individual worker windows.  Bug 1259603 is opened to use ConsoleEvents and expose console API messages to the frontend for those windows.  Andrea, I can't remember - what's the plan to get console service messages into the worker thread?

Comment 3

[Andrea Marchesini [:baku]]

> windows.  Andrea, I can't remember - what's the plan to get console service
> messages into the worker thread?

We don't have any plan yet. So far we dispatch Console messages generated by the console API.
We should find a way to connect ReportToAllClients to the Console API running in the worker thread.

Comment 4

[Eddy Bruel [:ejpbruel]]

Brian already answered Janx's question. I have nothing more to add.

Comment 5

[Andrew Overholt [:overholt]]

(In reply to Andrea Marchesini [:baku] from comment #3)
> > windows.  Andrea, I can't remember - what's the plan to get console service
> > messages into the worker thread?
> 
> We don't have any plan yet.

Has one materialized since you wrote this? :)

Comment 6

[Andrea Marchesini [:baku]]

Brian, do you confirm that the console API use in workers/SharedWorkers/ServiceWorkers is correctly shown in the worker debugger window?

Comment 7

[Brian Grinstead [:bgrins]]

Sorry for the delay in responding. The console API does not work for Service Workers or any workers when opening a toolbox to target that worker (this depends at least partly on Bug 1259603).  I'm going to be away for a few weeks, but if someone wanted to take over the patch in that bug it should be pretty close to landing - I think Eddy could review that code.  Landing it was held up by a test failure in the newly added test on that patch that I had trouble debugging, but we should at least get an initial landing here with or without that test.

Comment 8

[Brian Grinstead [:bgrins]]

OK, I'm getting close to having Bug 1259603 ready.  Let's re-purpose this bug for handling console service messages since console API messages will show up after that.

Comment 9

[Jens Stutte [:jstutte]]

Bulk-downgrade of unassigned, untouched DOM/Storage bug's priority.

If you have reason to believe, this is wrong, please write a comment and ni :jstutte.

Comment 10

[Kagami Rosylight [:saschanaz] (they/them)]

I can confirm that inspecting from about:debugging now properly shows messages.