Closed Bug 1280878 Opened 5 years ago Closed 5 years ago

Intermittent test_safe_browsing_notification.py TestSafeBrowsingNotificationBar.test_notification_bar | TimeoutException: Timed out after 30.1 seconds

Categories

(Testing :: Firefox UI Tests, defect)

Version 3
defect
Not set
normal

Tracking

(firefox49 wontfix, firefox-esr45 fixed, firefox50 fixed, firefox51 fixed, firefox52 fixed)

RESOLVED FIXED
mozilla52
Tracking Status
firefox49 --- wontfix
firefox-esr45 --- fixed
firefox50 --- fixed
firefox51 --- fixed
firefox52 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

https://treeherder.mozilla.org/logviewer.html#?job_id=4110551&repo=mozilla-central

 04:45:18     INFO - TEST-UNEXPECTED-ERROR | test_safe_browsing_notification.py TestSafeBrowsingNotificationBar.test_notification_bar | TimeoutException: TimeoutException: Timed out after 30.0 seconds
 04:45:18     INFO - Traceback (most recent call last):
 04:45:18     INFO -   File "/Users/mozauto/jenkins/workspace/mozilla-central_functional/build/venv/lib/python2.7/site-packages/marionette/marionette_test.py", line 344, in run
 04:45:18     INFO -     testMethod()
 04:45:18     INFO -   File "/Users/mozauto/jenkins/workspace/mozilla-central_functional/build/tests/firefox-ui/tests/functional/security/test_safe_browsing_notification.py", line 73, in test_notification_bar
 04:45:18     INFO -     self.check_not_badware_button(button_property, report_page)
 04:45:18     INFO -   File "/Users/mozauto/jenkins/workspace/mozilla-central_functional/build/tests/firefox-ui/tests/functional/security/test_safe_browsing_notification.py", line 113, in check_not_badware_button
 04:45:18     INFO -     lambda mn: report_page in mn.get_url())
 04:45:18     INFO -   File "/Users/mozauto/jenkins/workspace/mozilla-central_functional/build/venv/lib/python2.7/site-packages/marionette_driver/wait.py", line 144, in until
 04:45:18     INFO -     cause=last_exc)
04:45:18 INFO - TEST-INFO took 44851ms

Looks like we fail to load the report page.
No longer blocks: 1206134
Fixed by the proxy changes on bug 1289697.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
It still randomly fails due to networking issues. Lets keep it open to get more data.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Summary: TEST-UNEXPECTED-ERROR | test_safe_browsing_notification.py TestSafeBrowsingNotificationBar.test_notification_bar | TimeoutException: TimeoutException: Timed out after 30.0 seconds → Intermittent test_safe_browsing_notification.py TestSafeBrowsingNotificationBar.test_notification_bar | TimeoutException: Timed out after 30.1 seconds
:whimboo, yesterday this intermittent spiked:
https://brasstacks.mozilla.com/orangefactor/index.html?display=Bug&bugid=1280878&startday=2016-10-19&endday=2016-10-26&tree=trunk

can you take a look at this?  it is one of the top 5 intermittents.  It is split between different buildtypes for linux64 and appears to be split between opt-firefox-ui-functional-remote-e10s and opt-firefox-ui-functional-remote.
Flags: needinfo?(hskupin)
The failing line is here:

https://dxr.mozilla.org/mozilla-beta/source/testing/firefox-ui/tests/functional/security/test_safe_browsing_notification.py#113

It checks if the correct report page has been opened, and fails in that:

report page:
www.google.com/safebrowsing/report_error

current URL:
https://safebrowsing.google.com/safebrowsing/report_error/?tpl=mozilla&hl=en-US&url=https%3A%2F%2Fwww.itisatrap.org%2Ffirefox%2Fits-a-trap.html

So it looks like that Google actually has moved that page from the www subdomain to safebrowsing. I would suggest we remove the subdomain from the check and only check for the domain and fragment.
Assignee: nobody → hskupin
Status: REOPENED → ASSIGNED
Flags: needinfo?(hskupin)
Attachment #8804626 - Flags: review?(francois)
Because autolander is currently not working I pushed the try build myself:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f17fd98707e5af2294714e59c80c899ed562a6bc
Comment on attachment 8804626 [details]
Bug 1280878 - Update safebrowing_notification test for changed Google URL.

https://reviewboard.mozilla.org/r/88544/#review87700
Attachment #8804626 - Flags: review?(francois) → review+
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aff9d3eb8975
Update safebrowing_notification test for changed Google URL. r=francois
Whiteboard: [checkin-needed-aurora][checkin-needed-beta]
Target Milestone: mozilla50 → ---
https://hg.mozilla.org/mozilla-central/rev/aff9d3eb8975
Status: ASSIGNED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
https://hg.mozilla.org/releases/mozilla-aurora/rev/88cbb2726969
Whiteboard: [checkin-needed-aurora][checkin-needed-beta] → [checkin-needed-beta]
https://hg.mozilla.org/releases/mozilla-beta/rev/16e7406cee3d
Flags: in-testsuite+
Whiteboard: [checkin-needed-beta]
Depends on: 1120046
No longer depends on: 1120046
(In reply to Ryan VanderMeulen [:RyanVM] from comment #20)
> https://hg.mozilla.org/releases/mozilla-beta/rev/16e7406cee3d

Please note that the latest tests for Firefox 47.0.2 where broken because this patch wasn't part of mozilla-release until the merge from yesterday:

https://treeherder.mozilla.org/#/jobs?repo=mozilla-release&revision=d7f98b92fdeca9a662206667c68ec41a1476bdb7&selectedJob=318068&filter-searchStr=firefox%20functional&filter-tier=1&filter-tier=2&filter-tier=3
You need to log in before you can comment on or make changes to this bug.