Closed Bug 1280896 Opened 3 years ago Closed 3 years ago

Make mach eslint work for comm-central

Categories

(MailNews Core :: Build Config, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 50.0

People

(Reporter: Fallen, Assigned: Fallen)

References

Details

Attachments

(1 file)

mach eslint allows for some great code style fixes and as I am a fan of clean code I'd like to bring this to c-c.
Attached patch Fix - v1 β€” β€” Splinter Review
This is all we need to get started. I've ignored all directories we have, we can file separate bugs to enable per-directory once style guides have been defined and issues have been fixed.

Given we don't build using mach on automation, this will probably not run in nightly builds, but even running it locally is helpful.
Attachment #8763513 - Flags: review?(aleth)
Blocks: 1280898
Comment on attachment 8763513 [details] [diff] [review]
Fix - v1

Review of attachment 8763513 [details] [diff] [review]:
-----------------------------------------------------------------

Good idea! That looks surprisingly simple.
Attachment #8763513 - Flags: review?(aleth) → review+
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 50.0
You need to log in before you can comment on or make changes to this bug.