1280910 - Stop using HTTP API for looking up bug suggestions

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Data Ingestion, defect)

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] mozilla:bug_suggestions_no_http > mozilla:master

Comment 3

[Ed Morley [:emorley]]

Comment on attachment 8763562 [details] [review]
[treeherder] mozilla:bug_suggestions_no_http > mozilla:master

I had a branch for this locally, just hadn't gotten as far as opening a PR for it on Saturday after filing bug 1280761.

Looks good :-)

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/78bd30bb3b5b0e4c3a7fc40f102d809133b7b051
Bug 1280910 - Don't use HTTP API when looking up bug suggestions (#1605)

Comment 5

[Ed Morley [:emorley]]

Ah so this is unfortunately causing:
https://rpm.newrelic.com/accounts/677903/applications/14179733/traced_errors/e6f381-e32093fa-3804-11e6-bd66-b82a72d22a14

 exceptions:TypeError: datetime.datetime(2016, 6, 21, 8, 54, 16) is not JSON serializable 

This appears to be because `model_to_dict()` is triggering Django's lazy fetching of fields not specified in the queryset (perhaps model_to_dict just doesn't play nicely with RawQuerySets too?), and so we're getting the `modified` field from the table (in addition to `status`), when neither were present in the original dict.

Perhaps we should just switch back to the original mapping function?

Comment 6

[GitHub Autolander Bot]

Attachment: [treeherder] mozilla:bugscache_fixup > mozilla:master

Comment 7

[GitHub Autolander Bot]

Attachment: [treeherder] mozilla:bugscache_fixup > mozilla:master

Comment 8

[Ed Morley [:emorley]]

Comment on attachment 8764204 [details] [review]
[treeherder] mozilla:bugscache_fixup > mozilla:master

r+ with the SELECT statement change or else excluding `status` as well.

Comment 9

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/bc5c163b1d45c0494bc67fcae16e411826c8fbf1
Bug 1280910 - Don't return modified field for bug suggestions. (#1609)

This is not trivially JSON serializable and is not used, so just
exclude it