1280947 - DOM events not fired on interacting with <input type=file> element

Status: RESOLVED FIXED

Description

[Andreas Tolfsen ‹:ato›]

Events such as onchange are not being fired when “interacting”, or calling the Element Send Keys command, on <input type=file> elements.

This is probably because we have to use privileged chrome APIs to set the file on this element because we can’t use the interaction library.

Comment 2

[Andreas Tolfsen ‹:ato›]

Created attachment 8784866 [details]
Bug 1280947 - Improve names of JSON marshaling methods in Marionette client;

Review commit: https://reviewboard.mozilla.org/r/74170/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/74170/

Comment 3

[Andreas Tolfsen ‹:ato›]

Created attachment 8784867 [details]
Bug 1280947 - Support tuples for script arguments;

Tuples is are most commonly used in the Python standard library
to represent function argument iterables.

This patch changes the Marionette Python client to support both
tuples and lists.

Review commit: https://reviewboard.mozilla.org/r/74172/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/74172/

Comment 4

[Andreas Tolfsen ‹:ato›]

Created attachment 8784868 [details]
Bug 1280947 - Remove dead File object construction code;

Review commit: https://reviewboard.mozilla.org/r/74174/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/74174/

Comment 5

[Andreas Tolfsen ‹:ato›]

Created attachment 8784869 [details]
Bug 1280947 - Correct argument to event.sendEvent;

Events were not registered when constructed with an object
rather than a string literal.

Review commit: https://reviewboard.mozilla.org/r/74176/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/74176/

Comment 6

[Andreas Tolfsen ‹:ato›]

Created attachment 8784870 [details]
Bug 1280947 - Add event.change for dispatching DOM change events;

Review commit: https://reviewboard.mozilla.org/r/74178/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/74178/

Comment 7

[Andreas Tolfsen ‹:ato›]

Created attachment 8784871 [details]
Bug 1280947 - Dispatch DOM change event on appending file to input;

Review commit: https://reviewboard.mozilla.org/r/74180/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/74180/

Comment 8

[David Burns :automatedtester]

Comment on attachment 8784866 [details]
Bug 1280947 - Improve names of JSON marshaling methods in Marionette client;

https://reviewboard.mozilla.org/r/74170/#review72136

Comment 9

[David Burns :automatedtester]

Comment on attachment 8784867 [details]
Bug 1280947 - Support tuples for script arguments;

https://reviewboard.mozilla.org/r/74172/#review72142

Comment 10

[David Burns :automatedtester]

Comment on attachment 8784867 [details]
Bug 1280947 - Support tuples for script arguments;

https://reviewboard.mozilla.org/r/74172/#review72144

Comment 11

[David Burns :automatedtester]

Comment on attachment 8784868 [details]
Bug 1280947 - Remove dead File object construction code;

https://reviewboard.mozilla.org/r/74174/#review72146

Comment 12

[David Burns :automatedtester]

Comment on attachment 8784869 [details]
Bug 1280947 - Correct argument to event.sendEvent;

https://reviewboard.mozilla.org/r/74176/#review72148

Comment 13

[David Burns :automatedtester]

Comment on attachment 8784870 [details]
Bug 1280947 - Add event.change for dispatching DOM change events;

https://reviewboard.mozilla.org/r/74178/#review72150

::: testing/marionette/event.js:1336
(Diff revision 1)
>  
>  event.input = function(el, modifiers = {}, opts = {}) {
>    return event.sendEvent("input", el, modifiers, opts);
>  };
> +
> +event.change = function(el, modifiers = {}, opts = {}) {

This appears to be duplicate of lines 1328-1330

Comment 14

[David Burns :automatedtester]

Comment on attachment 8784871 [details]
Bug 1280947 - Dispatch DOM change event on appending file to input;

https://reviewboard.mozilla.org/r/74180/#review72152

Comment 15

[Andreas Tolfsen ‹:ato›]

Comment on attachment 8784870 [details]
Bug 1280947 - Add event.change for dispatching DOM change events;

https://reviewboard.mozilla.org/r/74178/#review72150

> This appears to be duplicate of lines 1328-1330

Oh, oops.

Comment 16

[Andreas Tolfsen ‹:ato›]

Comment on attachment 8784871 [details]
Bug 1280947 - Dispatch DOM change event on appending file to input;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/74180/diff/1-2/

Comment 17

[Andreas Tolfsen ‹:ato›]

Comment on attachment 8784871 [details]
Bug 1280947 - Dispatch DOM change event on appending file to input;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/74180/diff/2-3/

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/264c30a316b8
Improve names of JSON marshaling methods in Marionette client; r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/12b83f85ecfe
Support tuples for script arguments; r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/79da2701e6d9
Remove dead File object construction code; r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/3e33306995e3
Correct argument to event.sendEvent; r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/4ecaeb81b71e
Dispatch DOM change event on appending file to input; r=automatedtester

Comment 19

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/mozilla-central/rev/264c30a316b8
https://hg.mozilla.org/mozilla-central/rev/12b83f85ecfe
https://hg.mozilla.org/mozilla-central/rev/79da2701e6d9
https://hg.mozilla.org/mozilla-central/rev/3e33306995e3
https://hg.mozilla.org/mozilla-central/rev/4ecaeb81b71e

Comment 20

[Andreas Tolfsen ‹:ato›]

Test only changes.

Comment 21

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3933108db994
https://hg.mozilla.org/releases/mozilla-aurora/rev/e758a626321d
https://hg.mozilla.org/releases/mozilla-aurora/rev/ed0707148ece
https://hg.mozilla.org/releases/mozilla-aurora/rev/605a200c5938
https://hg.mozilla.org/releases/mozilla-aurora/rev/07b0869f14b0

Comment 22

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/releases/mozilla-beta/rev/b85804c6905a
https://hg.mozilla.org/releases/mozilla-beta/rev/7e91010b61c9
https://hg.mozilla.org/releases/mozilla-beta/rev/91d56ae239b2
https://hg.mozilla.org/releases/mozilla-beta/rev/e7599a44f0ae
https://hg.mozilla.org/releases/mozilla-beta/rev/64412641007c

Comment 23

[Wes Kocher (:KWierso)]

All backed out for both for Marionette bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=1571072&repo=mozilla-beta

https://hg.mozilla.org/releases/mozilla-aurora/rev/0a787a252077640330496045bdde5ca018ccc727
https://hg.mozilla.org/releases/mozilla-beta/rev/e3cc699ccef2abb7075c39e7b9a081718eb9c159

Comment 24

[Sylvestre Ledru [:sylvestre]]

David, do you know who could help with this? Thanks

Comment 25

[Andreas Tolfsen ‹:ato›]

It appears this depends on bug 1290966 to be uplifted first.  I’ve requested uplift for it.

Comment 26

[Andreas Tolfsen ‹:ato›]

Sheriffs: Please uplift bug 1290966 first, which should address earlier test failures on Aurora and Beta.  This patch series also consists of only test-only changes.

Comment 27

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4f4995c32e45
https://hg.mozilla.org/releases/mozilla-aurora/rev/63612dfd5140
https://hg.mozilla.org/releases/mozilla-aurora/rev/b96f561aa931
https://hg.mozilla.org/releases/mozilla-aurora/rev/f37bc538086e
https://hg.mozilla.org/releases/mozilla-aurora/rev/31baa11344d7

Comment 28

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/releases/mozilla-beta/rev/86304cd7d3c7
https://hg.mozilla.org/releases/mozilla-beta/rev/e505d3979c17
https://hg.mozilla.org/releases/mozilla-beta/rev/42cca15b776f
https://hg.mozilla.org/releases/mozilla-beta/rev/405f8c46ee5a
https://hg.mozilla.org/releases/mozilla-beta/rev/2591ed8e9b67

Comment 29

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/releases/mozilla-release/rev/86304cd7d3c7
https://hg.mozilla.org/releases/mozilla-release/rev/e505d3979c17
https://hg.mozilla.org/releases/mozilla-release/rev/42cca15b776f
https://hg.mozilla.org/releases/mozilla-release/rev/405f8c46ee5a
https://hg.mozilla.org/releases/mozilla-release/rev/2591ed8e9b67