DOM events not fired on interacting with <input type=file> element

RESOLVED FIXED in Firefox 50

Status

Testing
Marionette
RESOLVED FIXED
10 months ago
8 months ago

People

(Reporter: ato, Assigned: ato)

Tracking

(Blocks: 1 bug)

Version 3
mozilla51
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox49 wontfix, firefox50 fixed, firefox51 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(5 attachments, 1 obsolete attachment)

(Assignee)

Description

10 months ago
Events such as onchange are not being fired when “interacting”, or calling the Element Send Keys command, on <input type=file> elements.

This is probably because we have to use privileged chrome APIs to set the file on this element because we can’t use the interaction library.
(Assignee)

Updated

10 months ago
Blocks: 721859
(Assignee)

Updated

10 months ago
Duplicate of this bug: 1286107
(Assignee)

Updated

8 months ago
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

8 months ago
Blocks: 1244425

Comment 8

8 months ago
mozreview-review
Comment on attachment 8784866 [details]
Bug 1280947 - Improve names of JSON marshaling methods in Marionette client;

https://reviewboard.mozilla.org/r/74170/#review72136
Attachment #8784866 - Flags: review?(dburns) → review+

Comment 9

8 months ago
mozreview-review
Comment on attachment 8784867 [details]
Bug 1280947 - Support tuples for script arguments;

https://reviewboard.mozilla.org/r/74172/#review72142

Comment 10

8 months ago
mozreview-review
Comment on attachment 8784867 [details]
Bug 1280947 - Support tuples for script arguments;

https://reviewboard.mozilla.org/r/74172/#review72144
Attachment #8784867 - Flags: review?(dburns) → review+

Comment 11

8 months ago
mozreview-review
Comment on attachment 8784868 [details]
Bug 1280947 - Remove dead File object construction code;

https://reviewboard.mozilla.org/r/74174/#review72146
Attachment #8784868 - Flags: review?(dburns) → review+

Comment 12

8 months ago
mozreview-review
Comment on attachment 8784869 [details]
Bug 1280947 - Correct argument to event.sendEvent;

https://reviewboard.mozilla.org/r/74176/#review72148
Attachment #8784869 - Flags: review?(dburns) → review+

Comment 13

8 months ago
mozreview-review
Comment on attachment 8784870 [details]
Bug 1280947 - Add event.change for dispatching DOM change events;

https://reviewboard.mozilla.org/r/74178/#review72150

::: testing/marionette/event.js:1336
(Diff revision 1)
>  
>  event.input = function(el, modifiers = {}, opts = {}) {
>    return event.sendEvent("input", el, modifiers, opts);
>  };
> +
> +event.change = function(el, modifiers = {}, opts = {}) {

This appears to be duplicate of lines 1328-1330

Comment 14

8 months ago
mozreview-review
Comment on attachment 8784871 [details]
Bug 1280947 - Dispatch DOM change event on appending file to input;

https://reviewboard.mozilla.org/r/74180/#review72152
Attachment #8784871 - Flags: review?(dburns) → review+
(Assignee)

Comment 15

8 months ago
mozreview-review-reply
Comment on attachment 8784870 [details]
Bug 1280947 - Add event.change for dispatching DOM change events;

https://reviewboard.mozilla.org/r/74178/#review72150

> This appears to be duplicate of lines 1328-1330

Oh, oops.
Comment hidden (mozreview-request)
(Assignee)

Updated

8 months ago
Attachment #8784870 - Attachment is obsolete: true
Attachment #8784870 - Flags: review?(dburns)
Comment hidden (mozreview-request)

Comment 18

8 months ago
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/264c30a316b8
Improve names of JSON marshaling methods in Marionette client; r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/12b83f85ecfe
Support tuples for script arguments; r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/79da2701e6d9
Remove dead File object construction code; r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/3e33306995e3
Correct argument to event.sendEvent; r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/4ecaeb81b71e
Dispatch DOM change event on appending file to input; r=automatedtester

Comment 19

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/264c30a316b8
https://hg.mozilla.org/mozilla-central/rev/12b83f85ecfe
https://hg.mozilla.org/mozilla-central/rev/79da2701e6d9
https://hg.mozilla.org/mozilla-central/rev/3e33306995e3
https://hg.mozilla.org/mozilla-central/rev/4ecaeb81b71e
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
(Assignee)

Comment 20

8 months ago
Test only changes.
Whiteboard: [checkin-needed-aurora][checkin-needed-beta]

Comment 21

8 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/3933108db994
https://hg.mozilla.org/releases/mozilla-aurora/rev/e758a626321d
https://hg.mozilla.org/releases/mozilla-aurora/rev/ed0707148ece
https://hg.mozilla.org/releases/mozilla-aurora/rev/605a200c5938
https://hg.mozilla.org/releases/mozilla-aurora/rev/07b0869f14b0
status-firefox50: --- → fixed

Comment 22

8 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/b85804c6905a
https://hg.mozilla.org/releases/mozilla-beta/rev/7e91010b61c9
https://hg.mozilla.org/releases/mozilla-beta/rev/91d56ae239b2
https://hg.mozilla.org/releases/mozilla-beta/rev/e7599a44f0ae
https://hg.mozilla.org/releases/mozilla-beta/rev/64412641007c
status-firefox49: --- → fixed

Updated

8 months ago
Whiteboard: [checkin-needed-aurora][checkin-needed-beta]
All backed out for both for Marionette bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=1571072&repo=mozilla-beta

https://hg.mozilla.org/releases/mozilla-aurora/rev/0a787a252077640330496045bdde5ca018ccc727
https://hg.mozilla.org/releases/mozilla-beta/rev/e3cc699ccef2abb7075c39e7b9a081718eb9c159
status-firefox49: fixed → affected
status-firefox50: fixed → affected
Flags: needinfo?(ato)
David, do you know who could help with this? Thanks
status-firefox49: affected → wontfix
Flags: needinfo?(dburns)
(Assignee)

Comment 25

8 months ago
It appears this depends on bug 1290966 to be uplifted first.  I’ve requested uplift for it.
Depends on: 1290966
Flags: needinfo?(dburns)
Flags: needinfo?(ato)
(Assignee)

Comment 26

8 months ago
Sheriffs: Please uplift bug 1290966 first, which should address earlier test failures on Aurora and Beta.  This patch series also consists of only test-only changes.
Whiteboard: [checkin-needed-aurora][checkin-needed-beta]

Comment 27

8 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/4f4995c32e45
https://hg.mozilla.org/releases/mozilla-aurora/rev/63612dfd5140
https://hg.mozilla.org/releases/mozilla-aurora/rev/b96f561aa931
https://hg.mozilla.org/releases/mozilla-aurora/rev/f37bc538086e
https://hg.mozilla.org/releases/mozilla-aurora/rev/31baa11344d7
status-firefox50: affected → fixed

Comment 28

8 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/86304cd7d3c7
https://hg.mozilla.org/releases/mozilla-beta/rev/e505d3979c17
https://hg.mozilla.org/releases/mozilla-beta/rev/42cca15b776f
https://hg.mozilla.org/releases/mozilla-beta/rev/405f8c46ee5a
https://hg.mozilla.org/releases/mozilla-beta/rev/2591ed8e9b67

Comment 29

8 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-release/rev/86304cd7d3c7
https://hg.mozilla.org/releases/mozilla-release/rev/e505d3979c17
https://hg.mozilla.org/releases/mozilla-release/rev/42cca15b776f
https://hg.mozilla.org/releases/mozilla-release/rev/405f8c46ee5a
https://hg.mozilla.org/releases/mozilla-release/rev/2591ed8e9b67
Whiteboard: [checkin-needed-aurora][checkin-needed-beta]
You need to log in before you can comment on or make changes to this bug.