1281086 - |make buildsymbols| busted due to objdir being referenced as under build/mozilla

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Edmund Wong (:ewong)]

Seems as if there has been a change that has broken the 
|make buildsymbols| step (thus no builds as of late).

Following bustage:

building symbol store
rm -f -r dist/crashreporter-symbols
rm -f 'dist/seamonkey-2.47a1.en-US.linux-i686.crashreporter-symbols.zip'
rm -f 'dist/seamonkey-2.47a1.en-US.linux-i686.crashreporter-symbols-full.zip'
./config/nsinstall -D dist/crashreporter-symbols
OBJCOPY='/builds/slave/c-cen-t-lnx/build/gcc/bin/objcopy' \
/builds/slave/c-cen-t-lnx/build/objdir/_virtualenv/bin/python /builds/slave/c-cen-t-lnx/build/mozilla/toolkit/crashreporter/tools/symbolstore.py \
  -c --vcs-info --install-manifest=./_build_manifests/install/dist_include,dist/include                                          \
  -s /builds/slave/c-cen-t-lnx/build/mozilla               \
  dist/host/bin/dump_syms                                                \
  dist/crashreporter-symbols                                   \
  dist/bin | grep -iv test >                        \
  dist/crashreporter-symbols/seamonkey-2.47a1-Linux-20160620182904-x86-symbols.txt
Traceback (most recent call last):
  File "/builds/slave/c-cen-t-lnx/build/mozilla/toolkit/crashreporter/tools/symbolstore.py", line 24, in <module>
    import buildconfig
  File "/builds/slave/c-cen-t-lnx/build/mozilla/build/mach_bootstrap.py", line 380, in __call__
    module = self._original_import(name, globals, locals, fromlist, level)
  File "/builds/slave/c-cen-t-lnx/build/mozilla/build/buildconfig.py", line 9, in <module>
    config = MozbuildObject.from_environment()
  File "/builds/slave/c-cen-t-lnx/build/mozilla/python/mozbuild/mozbuild/base.py", line 184, in from_environment
    if not samepath(topobjdir, _config_topobjdir):
  File "/builds/slave/c-cen-t-lnx/build/mozilla/python/mozbuild/mozbuild/base.py", line 46, in samepath
    return os.path.samefile(path1, path2)
  File "/builds/slave/c-cen-t-lnx/build/objdir/_virtualenv/lib/python2.7/posixpath.py", line 163, in samefile
    s2 = os.stat(f2)
OSError: [Errno 2] No such file or directory: '/builds/slave/c-cen-t-lnx/build/mozilla/objdir'
make: *** [buildsymbols] Error 1
DEBUG: shell: unmounting all filesystems

Comment 1

[Edmund Wong (:ewong)]

Attachment: [buildbotcustom] proposed patch (v1)

this should unhork the bustage.

Comment 2

[Edmund Wong (:ewong)]

https://hg.mozilla.org/build/buildbotcustom/rev/ad0c4453728fd2d3340ab1c07fab68a10863cda3
Bug 1281086 - Add TOOLTOOL_DIR to the environment for the |make buildsymbols|

Comment 3

[Edmund Wong (:ewong)]

Comment on attachment 8764109 [details] [diff] [review]
[buildbotcustom] proposed patch (v1)

Pushed to buildbotcustom:
https://hg.mozilla.org/build/buildbotcustom/rev/ad0c4453728f

(for post-land-review)

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 8764109 [details] [diff] [review]
[buildbotcustom] proposed patch (v1)

if it works r+

Comment 5

[Edmund Wong (:ewong)]

Comment on attachment 8764109 [details] [diff] [review]
[buildbotcustom] proposed patch (v1)

This works for non-OSX64 builds. 

Unfortunately, for OSX64 builds, it tags a i386/ at the end of the
objdir path.

So now the buildsymbols is busted because of:

./config/nsinstall -D dist/crashreporter-symbols
OBJCOPY=':' \
	/builds/slave/c-aurora-osx64/build/objdir/i386/_virtualenv/bin/python /builds/slave/c-aurora-osx64/build/mozilla/toolkit/crashreporter/tools/symbolstore.py \
	  -c -a 'i386 x86_64' --vcs-info --install-manifest=./_build_manifests/install/dist_include,dist/include                                          \
	  -s /builds/slave/c-aurora-osx64/build/mozilla               \
	  dist/host/bin/dump_syms                                                \
	  dist/crashreporter-symbols                                   \
	  dist/universal | grep -iv test >                        \
	  dist/crashreporter-symbols/seamonkey-2.47a2-Darwin-20160815115324-x86-symbols.txt
Traceback (most recent call last):
  File "/builds/slave/c-aurora-osx64/build/mozilla/toolkit/crashreporter/tools/symbolstore.py", line 24, in <module>
    import buildconfig
  File "/builds/slave/c-aurora-osx64/build/mozilla/build/mach_bootstrap.py", line 369, in __call__
    module = self._original_import(name, globals, locals, fromlist, level)
  File "/builds/slave/c-aurora-osx64/build/mozilla/build/buildconfig.py", line 9, in <module>
    config = MozbuildObject.from_environment()
  File "/builds/slave/c-aurora-osx64/build/mozilla/python/mozbuild/mozbuild/base.py", line 183, in from_environment
    if not samepath(topobjdir, _config_topobjdir):
  File "/builds/slave/c-aurora-osx64/build/mozilla/python/mozbuild/mozbuild/base.py", line 46, in samepath
    return os.path.samefile(path1, path2)
  File "/builds/slave/c-aurora-osx64/build/objdir/i386/_virtualenv/lib/python2.7/posixpath.py", line 154, in samefile
    s2 = os.stat(f2)
OSError: [Errno 2] No such file or directory: '/builds/slave/c-aurora-osx64/build/objdir/i386/i386'
make: *** [buildsymbols] Error 1

in c-b and c-r, this is ok.  However, in c-a (and I suspect, c-c, which
is currently busted and is waiting for the buildslaves to catch
up), it isn't.  So I suspect there has been a change somewhere along
the line that I missed. and I suspect it's one that loops the buildsymbols
rule for i386 and x64.  So I'm guessing we're either behind in the
buildconfig, or I need to figure it out in the buildbotcustom code..

Comment 6

[Edmund Wong (:ewong)]

Comment on attachment 8764109 [details] [diff] [review]
[buildbotcustom] proposed patch (v1)

This was backed out:

https://hg.mozilla.org/build/buildbotcustom/rev/e8f0c256a350

Not the fix we're looking for...

Comment 7

[Edmund Wong (:ewong)]

Attachment: [buildbotcustom] set MOZ_OBJDIR properly earlier [checked-in]

Comment 8

[Edmund Wong (:ewong)]

https://hg.mozilla.org/build/buildbotcustom/rev/1546531f22943c85b9aad9f307952f2319e2c6a0
Bug 1281086 - add MOZ_OBJDIR with the correct objdir path earlier on. r=bustagefix

Comment 9

[Edmund Wong (:ewong)]

Comment on attachment 8782297 [details] [diff] [review]
[buildbotcustom] set MOZ_OBJDIR properly earlier [checked-in]

As per Callek's approval on irc, I'm closing bugs that have patches which have been pushed already.