Closed
Bug 1281101
Opened 8 years ago
Closed 7 years ago
Remove MOZ_ENABLE_MASK_AS_SHORTHAND
Categories
(Core :: Layout, defect, P3)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: u459114, Assigned: TYLin)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
After mask image release and get stable, we can remove MOZ_ENABLE_MASK_AS_SHORTHAND compile flag and relative code 1. Remove MOZ_ENABLE_MASK_AS_SHORTHAND in old-configure.in 2. Remove c++ code segements contained in #ifdef MOZ_ENABLE_MASK_AS_SHORTHAND. 3. Remove mask-image support-check in mochitest, such as if("maskImage" in document.documentElement.style) statement.
Updated•7 years ago
|
Priority: -- → P3
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → tlin
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8910674 -
Flags: review?(cku)
Attachment #8910675 -
Flags: review?(cku)
Attachment #8910676 -
Flags: review?(ted)
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8910676 [details] Bug 1281101 Part 3 - Remove MOZ_ENABLE_MASK_AS_SHORTHAND in old-configure.in. https://reviewboard.mozilla.org/r/182126/#review187514
Attachment #8910676 -
Flags: review?(ted) → review+
Comment on attachment 8910674 [details] Bug 1281101 Part 1 - Remove MOZ_ENABLE_MASK_AS_SHORTHAND from layout code. https://reviewboard.mozilla.org/r/182122/#review187784
Attachment #8910674 -
Flags: review?(cku) → review+
Comment on attachment 8910675 [details] Bug 1281101 Part 2 - Remove mask-image support checking in mochitests. https://reviewboard.mozilla.org/r/182124/#review187786
Attachment #8910675 -
Flags: review?(cku) → review+
Assignee | ||
Comment 7•7 years ago
|
||
I forgot to remove SupportsMaskShorthand() in layout/style/test/test_transitions_per_property.html. I'll fix that in Part 2. https://treeherder.mozilla.org/#/jobs?repo=try&revision=09985c42b66d
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 10•7 years ago
|
||
Pushed by tlin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/01ca10935e7f Part 1 - Remove MOZ_ENABLE_MASK_AS_SHORTHAND from layout code. r=cjku https://hg.mozilla.org/integration/autoland/rev/b90d37b76de3 Part 2 - Remove mask-image support checking in mochitests. r=cjku https://hg.mozilla.org/integration/autoland/rev/d1a33bf606e5 Part 3 - Remove MOZ_ENABLE_MASK_AS_SHORTHAND in old-configure.in. r=ted
Comment 11•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/01ca10935e7f https://hg.mozilla.org/mozilla-central/rev/b90d37b76de3 https://hg.mozilla.org/mozilla-central/rev/d1a33bf606e5
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•