1281101 - Remove MOZ_ENABLE_MASK_AS_SHORTHAND

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[u459114]

After mask image release and get stable, we can remove MOZ_ENABLE_MASK_AS_SHORTHAND compile flag and relative code
1. Remove MOZ_ENABLE_MASK_AS_SHORTHAND in old-configure.in
2. Remove c++ code segements contained in #ifdef MOZ_ENABLE_MASK_AS_SHORTHAND.
3. Remove mask-image support-check in mochitest, such as if("maskImage" in document.documentElement.style) statement.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1281101 Part 1 - Remove MOZ_ENABLE_MASK_AS_SHORTHAND from layout code.

Review commit: https://reviewboard.mozilla.org/r/182122/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/182122/

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1281101 Part 2 - Remove mask-image support checking in mochitests.

Review commit: https://reviewboard.mozilla.org/r/182124/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/182124/

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1281101 Part 3 - Remove MOZ_ENABLE_MASK_AS_SHORTHAND in old-configure.in.

Review commit: https://reviewboard.mozilla.org/r/182126/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/182126/

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 8910676 [details]
Bug 1281101 Part 3 - Remove MOZ_ENABLE_MASK_AS_SHORTHAND in old-configure.in.

https://reviewboard.mozilla.org/r/182126/#review187514

Comment 5

[u459114]

Comment on attachment 8910674 [details]
Bug 1281101 Part 1 - Remove MOZ_ENABLE_MASK_AS_SHORTHAND from layout code.

https://reviewboard.mozilla.org/r/182122/#review187784

Comment 6

[u459114]

Comment on attachment 8910675 [details]
Bug 1281101 Part 2 - Remove mask-image support checking in mochitests.

https://reviewboard.mozilla.org/r/182124/#review187786

Comment 7

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

I forgot to remove SupportsMaskShorthand() in layout/style/test/test_transitions_per_property.html. I'll fix that in Part 2.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=09985c42b66d

Comment 8

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Comment on attachment 8910675 [details]
Bug 1281101 Part 2 - Remove mask-image support checking in mochitests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/182124/diff/1-2/

Comment 9

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Comment on attachment 8910676 [details]
Bug 1281101 Part 3 - Remove MOZ_ENABLE_MASK_AS_SHORTHAND in old-configure.in.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/182126/diff/1-2/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01ca10935e7f
Part 1 - Remove MOZ_ENABLE_MASK_AS_SHORTHAND from layout code. r=cjku
https://hg.mozilla.org/integration/autoland/rev/b90d37b76de3
Part 2 - Remove mask-image support checking in mochitests. r=cjku
https://hg.mozilla.org/integration/autoland/rev/d1a33bf606e5
Part 3 - Remove MOZ_ENABLE_MASK_AS_SHORTHAND in old-configure.in. r=ted

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/01ca10935e7f
https://hg.mozilla.org/mozilla-central/rev/b90d37b76de3
https://hg.mozilla.org/mozilla-central/rev/d1a33bf606e5