If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Remove MOZ_ENABLE_MASK_AS_SHORTHAND

RESOLVED FIXED in Firefox 58

Status

()

Core
Layout
P3
normal
RESOLVED FIXED
a year ago
3 days ago

People

(Reporter: cjku, Assigned: TYLin)

Tracking

(Blocks: 1 bug)

unspecified
mozilla58
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox58 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Reporter)

Description

a year ago
After mask image release and get stable, we can remove MOZ_ENABLE_MASK_AS_SHORTHAND compile flag and relative code
1. Remove MOZ_ENABLE_MASK_AS_SHORTHAND in old-configure.in
2. Remove c++ code segements contained in #ifdef MOZ_ENABLE_MASK_AS_SHORTHAND.
3. Remove mask-image support-check in mochitest, such as if("maskImage" in document.documentElement.style) statement.
Depends on: 1251161

Updated

2 months ago
Priority: -- → P3
(Assignee)

Updated

4 days ago
Assignee: nobody → tlin
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

4 days ago
Attachment #8910674 - Flags: review?(cku)
Attachment #8910675 - Flags: review?(cku)
Attachment #8910676 - Flags: review?(ted)
Comment on attachment 8910676 [details]
Bug 1281101 Part 3 - Remove MOZ_ENABLE_MASK_AS_SHORTHAND in old-configure.in.

https://reviewboard.mozilla.org/r/182126/#review187514
Attachment #8910676 - Flags: review?(ted) → review+
(Reporter)

Comment 5

4 days ago
mozreview-review
Comment on attachment 8910674 [details]
Bug 1281101 Part 1 - Remove MOZ_ENABLE_MASK_AS_SHORTHAND from layout code.

https://reviewboard.mozilla.org/r/182122/#review187784
Attachment #8910674 - Flags: review?(cku) → review+
(Reporter)

Comment 6

4 days ago
mozreview-review
Comment on attachment 8910675 [details]
Bug 1281101 Part 2 - Remove mask-image support checking in mochitests.

https://reviewboard.mozilla.org/r/182124/#review187786
Attachment #8910675 - Flags: review?(cku) → review+
(Assignee)

Comment 7

4 days ago
I forgot to remove SupportsMaskShorthand() in layout/style/test/test_transitions_per_property.html. I'll fix that in Part 2.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=09985c42b66d
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 10

3 days ago
Pushed by tlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/01ca10935e7f
Part 1 - Remove MOZ_ENABLE_MASK_AS_SHORTHAND from layout code. r=cjku
https://hg.mozilla.org/integration/autoland/rev/b90d37b76de3
Part 2 - Remove mask-image support checking in mochitests. r=cjku
https://hg.mozilla.org/integration/autoland/rev/d1a33bf606e5
Part 3 - Remove MOZ_ENABLE_MASK_AS_SHORTHAND in old-configure.in. r=ted
https://hg.mozilla.org/mozilla-central/rev/01ca10935e7f
https://hg.mozilla.org/mozilla-central/rev/b90d37b76de3
https://hg.mozilla.org/mozilla-central/rev/d1a33bf606e5
Status: ASSIGNED → RESOLVED
Last Resolved: 3 days ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.