1281119 - Check existence of event.detail.swipe before converting touchend events into key events for remote-control service

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::TV, defect)

Description

[C.M.Chang[:chunmin]]

The remote-control server on TV side will convert the touch events sent from Fennec side into the key events by the "swipe" value of the "touchend" messages[0] if the control mode is not "cursor" mode.

However, the "swipe" might not exist in touchend messages. There is a move threshold for touch-pad control to filter the input of inadvertent touch. Thus, I think we might need to check existence of event.detail.swipe before converting touchend events into key events[2].


[0] https://wiki.mozilla.org/Firefox_OS/Remote_Control#Touch_Events
[1] https://github.com/ChunMinChang/fennec-fxos-tv/blob/master/content/remote-control-client/js/panel_element.js#L11
[2] https://github.com/mozilla-b2g/gecko-b2g/blob/b2g48_v2_6/b2g/chrome/content/remote_command.js#L133

Comment 1

[C.M.Chang[:chunmin]]

Attachment: [v1] check event.detail.swipe of touchend events

Hi SC,
Could you review this small change?

Comment 2

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Comment on attachment 8763809 [details] [diff] [review]
[v1] check event.detail.swipe of touchend events

Review of attachment 8763809 [details] [diff] [review]:
-----------------------------------------------------------------

If |detail.swipe| is not existed, it shall fall into default case and does nothing. Not sure why this modification make difference.

Comment 3

[C.M.Chang[:chunmin]]

Oh yeah, it my bad. False alarm!