1281150 - Remove obsolete RTCDataChannel.stream property

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P2)

Description

[Eric Shepherd [:sheppy]]

I don't see a bug for this, so I figured I'd get it on file. The comment in DataChannel.webidl (https://dxr.mozilla.org/mozilla-central/source/dom/webidl/DataChannel.webidl) says the old stream property was left in "for Fx22", and here we are at Fx50 or so and it's still there. When will the time come to actually remove this property?

Comment 1

[Nils Ohlmeier [:drno]]

Attachment: Bug 1281150: removed DataChannel.stream.

Review commit: https://reviewboard.mozilla.org/r/60024/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/60024/

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

https://reviewboard.mozilla.org/r/60024/#review56934

You'll need a DOM peer reviewer as well, e.g. smaug.

::: dom/webidl/DataChannel.webidl
(Diff revision 1)
>  {
>    readonly attribute DOMString protocol;
>    readonly attribute boolean ordered;
>    readonly attribute unsigned short id;
> -  // this is deprecated due to renaming in the spec, but still supported for Fx22
> -  readonly attribute unsigned short stream; // now id

You'll want to remove this as well:

https://dxr.mozilla.org/mozilla-central/source/dom/base/nsIDOMDataChannel.idl#28

and any code it supports.

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8763901 [details]
Bug 1281150: removed DataChannel.stream.

https://reviewboard.mozilla.org/r/60024/#review56936

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

If you're doing cleaning...

Comment 5

[Nils Ohlmeier [:drno]]

Comment on attachment 8763901 [details]
Bug 1281150: removed DataChannel.stream.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/60024/diff/1-2/

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8763901 [details]
Bug 1281150: removed DataChannel.stream.

https://reviewboard.mozilla.org/r/60024/#review56988

Hopefully no one is using this. But given this is webrtc, I guess users should be expecting very must no guarantee on backwards compatibility ;)

Comment 7

[Eric Shepherd [:sheppy]]

Given how out of date most documentation out there is, you never know what people are doing with WebRTC.

Comment 8

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8763901 [details]
Bug 1281150: removed DataChannel.stream.

https://reviewboard.mozilla.org/r/60024/#review57020

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a048fe8e467d
removed DataChannel.stream. r=jib,smaug

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a048fe8e467d

Comment 11

[Eric Shepherd [:sheppy]]

I love when things work so smoothly. This change is now listed on Firefox 50 for developers: https://developer.mozilla.org/en-US/Firefox/Releases/50#WebRTC

I've also created this page, just for the sake of completeness: https://developer.mozilla.org/en-US/docs/Web/API/RTCDataChannel/stream

Comment 12

[Kohei Yoshino [:kohei]]

Posted the site compatibility doc: https://www.fxsitecompat.com/en-CA/docs/2016/rtcdatachannel-stream-has-been-removed/