Closed
Bug 1281192
Opened 9 years ago
Closed 9 years ago
Tweak displayport prefs
Categories
(Firefox for Android Graveyard :: Toolbar, defect, P2)
Tracking
(firefox47 unaffected, firefox48 fixed, firefox49 fixed, firefox50 fixed)
RESOLVED
FIXED
Firefox 50
Tracking | Status | |
---|---|---|
firefox47 | --- | unaffected |
firefox48 | --- | fixed |
firefox49 | --- | fixed |
firefox50 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
Details
(Keywords: perf)
Attachments
(2 files)
58 bytes,
text/x-review-board-request
|
rbarker
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details |
58 bytes,
text/x-review-board-request
|
rbarker
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details |
Scrolling around on planet, I see the displayport move around excessively. I think we should turn off velocity bias and make the vertival displayport multiplier the same in both stationary and skate modes. That should stop the displayport from resizing and moving so much. I suspect the Android scroller velocity fluctuates more than the APZ one, which might be this is more obvious on Fennec than on other platforms. Still, we made these same changes on desktop and it helped somewhat so it's worth doing on Fennec as well.
Assignee | ||
Updated•9 years ago
|
Priority: -- → P2
Assignee | ||
Comment 1•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/60060/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/60060/
Attachment #8763997 -
Flags: review?(rbarker)
Attachment #8763998 -
Flags: review?(rbarker)
Assignee | ||
Comment 2•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/60062/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/60062/
Comment 3•9 years ago
|
||
Comment on attachment 8763997 [details]
Bug 1281192 - Set velocity bias to 0 on Fennec.
https://reviewboard.mozilla.org/r/60060/#review56938
Attachment #8763997 -
Flags: review?(rbarker) → review+
Comment 4•9 years ago
|
||
Comment on attachment 8763998 [details]
Bug 1281192 - Make the Fennec stationary displayport height multiplier match the corresponding skate multiplier to avoid constant resizing.
https://reviewboard.mozilla.org/r/60062/#review56940
Attachment #8763998 -
Flags: review?(rbarker) → review+
Assignee | ||
Updated•9 years ago
|
status-firefox47:
--- → unaffected
status-firefox48:
--- → affected
status-firefox49:
--- → affected
status-firefox50:
--- → affected
Keywords: perf
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a41aeca40d0
Set velocity bias to 0 on Fennec. r=rbarker
https://hg.mozilla.org/integration/mozilla-inbound/rev/d7d39bfb71ad
Make the Fennec stationary displayport height multiplier match the corresponding skate multiplier to avoid constant resizing. r=rbarker
Comment 6•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2a41aeca40d0
https://hg.mozilla.org/mozilla-central/rev/d7d39bfb71ad
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8763997 [details]
Bug 1281192 - Set velocity bias to 0 on Fennec.
Approval Request Comment
[Feature/regressing bug #]: APZ on Fennec
[User impact if declined]: While scrolling around, the displayport jumps and resizes quite a bit, which can lead to wasting time during paint. So basically slightly degraded performance while scrolling.
[Describe test coverage new/current, TreeHerder]: Manual testing only
[Risks and why]: low risk, just a couple of pref tweaks
[String/UUID change made/needed]: none
Attachment #8763997 -
Flags: approval-mozilla-beta?
Attachment #8763997 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•9 years ago
|
Attachment #8763998 -
Flags: approval-mozilla-beta?
Attachment #8763998 -
Flags: approval-mozilla-aurora?
Comment 8•9 years ago
|
||
Comment on attachment 8763997 [details]
Bug 1281192 - Set velocity bias to 0 on Fennec.
Fix a recent regression, taking it.
Should be in 48 beta 4.
Attachment #8763997 -
Flags: approval-mozilla-beta?
Attachment #8763997 -
Flags: approval-mozilla-beta+
Attachment #8763997 -
Flags: approval-mozilla-aurora?
Attachment #8763997 -
Flags: approval-mozilla-aurora+
Updated•9 years ago
|
Attachment #8763998 -
Flags: approval-mozilla-beta?
Attachment #8763998 -
Flags: approval-mozilla-beta+
Attachment #8763998 -
Flags: approval-mozilla-aurora?
Attachment #8763998 -
Flags: approval-mozilla-aurora+
Comment 9•9 years ago
|
||
bugherder uplift |
Comment 10•9 years ago
|
||
bugherder uplift |
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•