1281192 - Tweak displayport prefs

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect, P2)

Description

[Kartikaya Gupta (email:[e-mail])]

Scrolling around on planet, I see the displayport move around excessively. I think we should turn off velocity bias and make the vertival displayport multiplier the same in both stationary and skate modes. That should stop the displayport from resizing and moving so much. I suspect the Android scroller velocity fluctuates more than the APZ one, which might be this is more obvious on Fennec than on other platforms. Still, we made these same changes on desktop and it helped somewhat so it's worth doing on Fennec as well.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1281192 - Set velocity bias to 0 on Fennec.

Review commit: https://reviewboard.mozilla.org/r/60060/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/60060/

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1281192 - Make the Fennec stationary displayport height multiplier match the corresponding skate multiplier to avoid constant resizing.

Review commit: https://reviewboard.mozilla.org/r/60062/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/60062/

Comment 3

[Randall Barker [:rbarker]]

Comment on attachment 8763997 [details]
Bug 1281192 - Set velocity bias to 0 on Fennec.

https://reviewboard.mozilla.org/r/60060/#review56938

Comment 4

[Randall Barker [:rbarker]]

Comment on attachment 8763998 [details]
Bug 1281192 - Make the Fennec stationary displayport height multiplier match the corresponding skate multiplier to avoid constant resizing.

https://reviewboard.mozilla.org/r/60062/#review56940

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a41aeca40d0
Set velocity bias to 0 on Fennec. r=rbarker
https://hg.mozilla.org/integration/mozilla-inbound/rev/d7d39bfb71ad
Make the Fennec stationary displayport height multiplier match the corresponding skate multiplier to avoid constant resizing. r=rbarker

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2a41aeca40d0
https://hg.mozilla.org/mozilla-central/rev/d7d39bfb71ad

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8763997 [details]
Bug 1281192 - Set velocity bias to 0 on Fennec.

Approval Request Comment
[Feature/regressing bug #]: APZ on Fennec
[User impact if declined]: While scrolling around, the displayport jumps and resizes quite a bit, which can lead to wasting time during paint. So basically slightly degraded performance while scrolling.
[Describe test coverage new/current, TreeHerder]: Manual testing only
[Risks and why]: low risk, just a couple of pref tweaks
[String/UUID change made/needed]: none

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8763997 [details]
Bug 1281192 - Set velocity bias to 0 on Fennec.

Fix a recent regression, taking it.
Should be in 48 beta 4.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2f5a8216aaa5
https://hg.mozilla.org/releases/mozilla-aurora/rev/bb8525b71ab4

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e1d4e297d894
https://hg.mozilla.org/releases/mozilla-beta/rev/07337b29c24d