1281193 - Intermittent browser_devices_get_user_media.js | application crashed [@ mozilla::MediaStreamGraphImpl::AudioTrackPresent(bool &)]

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: wkocher

https://treeherder.allizom.org/logviewer.html#?job_id=27648527&repo=mozilla-inbound

http://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-win32-debug/1466513820/mozilla-inbound_win7_ix-debug_test-mochitest-browser-chrome-7-bm112-tests1-windows-build55.txt.gz

Comment 1

[Paul Adenot (:padenot)]

Have we landed anything weird that would crash on `data.mData` ?

Comment 2

[Andreas Pehrson [:pehrsons]]

No, and we're never adding a track with a null MediaSegment.

Are we holding onto the SourceMediaStream mutex in AudioTrackPresent though? It could be racing against SourceMediaStream::AddTrackInternal().

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1281193 - Lock when touching tracks in SourceAudioStreams.

Review commit: https://reviewboard.mozilla.org/r/60270/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/60270/

Comment 4

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8764302 [details]
Bug 1281193 - Lock when touching tracks in SourceAudioStreams.

https://reviewboard.mozilla.org/r/60270/#review57096

::: dom/media/MediaStreamGraph.h:1098
(Diff revision 1)
>    void RegisterForAudioMixing();
>  
> +  /**
> +   * Returns true if this SourceMediaStream contains at least one audio track
> +   * that is in pending state.
> +   * This is thread safe, and takes the stream monitor.

s/stream monitor/SourceMediaStream mutex/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/68ed15400143
Lock when touching tracks in SourceAudioStreams. r=pehrsons

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/68ed15400143

Comment 7

[Maire Reavy [:mreavy]]

Paul -- Since this is a crash, does it make sense to ask for uplift to Fx 49 (Aurora)?

Comment 8

[Paul Adenot (:padenot)]

Comment on attachment 8764302 [details]
Bug 1281193 - Lock when touching tracks in SourceAudioStreams.

Approval Request Comment
[Feature/regressing bug #]: unclear, probably duplex initial landing in 48
[User impact if declined]: crash
[Describe test coverage new/current, TreeHerder]: there was an intermittent, it's now fixed
[Risks and why]: very small patch for a very obvious issue 
[String/UUID change made/needed]: none

Comment 9

[Gerry Chang [:gchang]]

Comment on attachment 8764302 [details]
Bug 1281193 - Lock when touching tracks in SourceAudioStreams.

This patch fixes an intermittent error. Take it in aurora.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/822a68704ed4