1281329 - Bug filer files in the first search result for product/component, not the selected one

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[Phil Ringnalda (:philor)]

STR that won't spew bugs at wrong components first:

1. Click the file a bug icon for a failure for which you can engineer a search with two or more components with the first one correct, like a canvas failure where a search for "canvas" will suggest Core::Canvas 2D as the first result, and Canvas: WebGL as the second
2. Click the radio button to file in the second search result, even though the first is the one you actually want, and file the bug

Expected: Canvas: WebGL, since that was selected. Actual: Canvas: 2D, which was the first search result.

Less recommended steps: filing a bug with any of the dozens of terms which make an unwanted "Developer Documentation" component the first results; trying to file in Core::General since there's no possible way to avoid Chat Core::General being the first result.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://github.com/mozilla/treeherder/blob/master/ui/js/controllers/bugfiler.js#L124 seems wrong. Will fix.

Comment 2

[GitHub Autolander Bot]

Attachment: [treeherder] KWierso:1281329 > mozilla:master

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8764086 [details] [review]
[treeherder] KWierso:1281329 > mozilla:master

Ed, I think this should work around the problem, at least until Cam's back with a real fix. 

For whatever reason, the change to selectedProduct wasn't being reflected automatically despite the ng-model, so this just forces it manually onClick().

The filer is hidden behind the url parameter, so this could wait for Cam to come back if you don't feel up for the review. :)

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8764086 [details] [review]
[treeherder] KWierso:1281329 > mozilla:master

I think this should work.

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/fae010f9c0423f1d9dc51de8b56a9dd1884429c6
Bug 1281329 - Ensure selectedProduct gets updated when a new product is selected(#1608) r=emorley