1281408 - Crash producing memory report [@ mozilla::dom::MediaStreamAudioSourceNode::SizeOfIncludingThis]

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, defect, P2)

Description

[Jesse Ruderman]

Attachment: testcase (manual version - use about:memory to crash)

1. Load the testcase
2. Open about:memory
3. Click "Measure"

Crashes with a RefPtr null deref in debug builds, but does not crash in non-debug ASan builds.

Comment 1

[Jesse Ruderman]

Attachment: testcase (automated version)

Comment 2

[Jesse Ruderman]

Attachment: stack

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1281408 - Nullcheck `mInputPort` in MediaStreamAudioSourceNode to prevent crashing when getting memory reports after the underlying MediaStream has been destroyed.

Review commit: https://reviewboard.mozilla.org/r/60276/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/60276/

Comment 4

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8764313 [details]
Bug 1281408 - Nullcheck `mInputPort` in MediaStreamAudioSourceNode to prevent crashing when getting memory reports after the underlying MediaStream has been destroyed.

https://reviewboard.mozilla.org/r/60276/#review57098

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f35504e8fc9d
Nullcheck `mInputPort` in MediaStreamAudioSourceNode to prevent crashing when getting memory reports after the underlying MediaStream has been destroyed. r=pehrsons

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f35504e8fc9d