1281463 - The log parser fetches the JobLog object twice for each log

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Data Ingestion, defect, P2)

Description

[Ed Morley [:emorley]]

https://rpm.newrelic.com/accounts/677903/applications/4180461/transactions?type=other&show_browser=false#id=5b224f746865725472616e73616374696f6e2f43656c6572792f6c6f672d706172736572222c22225d

MySQL job_log select: average 2 calls per transaction

Whilst this was refactored in bug 1273231, bug 1252854 is what added the call to tasks.py that makes the utils.py call redundant.

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] mozilla:parse-log-cleanup > mozilla:master

Comment 2

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/8d43e3cde312414fb77bac505326a47801b04758
Bug 1281463 - Stop passing get_error_summary_artifacts as a callback

Since we only ever pass in one type of callback, and it makes the code
harder to follow.

https://github.com/mozilla/treeherder/commit/8c211be066f94fb7c418d5a91e5c1341854ec71f
Bug 1281463 - Remove unnecessary second JobLog fetch

Since it's already fetched as part of the `parser_task` decorator.

https://github.com/mozilla/treeherder/commit/ea9944283c30f17c02c83b2c925a1fc471292fbb
Bug 1281463 - Move credentials fetching to closer to their usage

https://github.com/mozilla/treeherder/commit/0fd6cb17d5f591ef9730324ec5eb465e12e86bfe
Bug 1281463 - Use .get_FOO_display() rather than mapping manually

https://docs.djangoproject.com/en/1.8/ref/models/instances/#django.db.models.Model.get_FOO_display