128147 - Cant use ProgressDialog directly with nsIChannel's

Status: RESOLVED WONTFIX

(Core Graveyard :: Embedding: APIs, defect)

Description

[Doug Turner (:dougt)]

To make the progress dialog easier to use by the nsIChannels, it should
implement the following interfaces:


nsIProgressEventSink
nsIInterfaceRequestor

In this way, the progress dialog can be opened and directly attached to a channel.

Comment 1

[Doug Turner (:dougt)]

Attachment: Impl. my suggestions

Comment 2

[Bill Law]

Doug, I think this is a worthwhile extension.

Questions: 

What about handling errors that come through onStatus?  Presumably, those would
need to be translated into calls to the onStatusChange method.  There might also
have to be some filtering to ensure that only errors go through (similar to what
nsWebBrowserPersist::OnStatus does).

Wouldn't we also have to hook into nsIStreamListener methods for OnStopRequest
notifications (with mapping to OnStateChange)?

Maybe another approach would be to write a generalized wrapper class that
implements nsIWebProgressListener around a nsIProgressEventSink and
nsIStreamListener?

Comment 3

[Doug Turner (:dougt)]

>Maybe another approach would be to write a generalized wrapper class that
implements nsIWebProgressListener around a nsIProgressEventSink and
nsIStreamListener?

Yes.  that is the best thing to do.  An adaptor class.  Are you up to do this?

Comment 4

[Doug Turner (:dougt)]

The only problem is that, we could not use your interface directly. :-(

Comment 5

[Bill Law]

OK, maybe the adapter isn't worth the trouble.  But I still don't have time to
deal with this, unless you get it marked nsbeta1+ and added to my mozilla1.0 bug
list.

Comment 6

[Bill Law]

Charlie is interested in this, too.  Maybe he can help out?

Comment 7

[Judson Valeski]

-> law

Comment 8

[Jan Varga [:janv]]

-> me

Comment 9

[Jan Varga [:janv]]

-> me

Comment 10

[Darin Fisher]

i'm going to mark this WONTFIX based on the fact that it is easy enough to use
nsIWebBrowserPersist + nsIProgressDialog to achieve the effect.  if someone
really wants this, then please speak up ;-)

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

(In reply to comment #10)
> i'm going to mark this WONTFIX based on the fact that it is easy enough to use
> nsIWebBrowserPersist + nsIProgressDialog to achieve the effect.  if someone
> really wants this, then please speak up ;-)

well... you actually implemented nsIInterfaceRequestor on it...