Closed Bug 128147 Opened 21 years ago Closed 19 years ago

Cant use ProgressDialog directly with nsIChannel's

Categories

(Core Graveyard :: Embedding: APIs, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: dougt, Assigned: janv)

References

Details

Attachments

(1 file)

To make the progress dialog easier to use by the nsIChannels, it should
implement the following interfaces:


nsIProgressEventSink
nsIInterfaceRequestor

In this way, the progress dialog can be opened and directly attached to a channel.
Blocks: 24867
Doug, I think this is a worthwhile extension.

Questions: 

What about handling errors that come through onStatus?  Presumably, those would
need to be translated into calls to the onStatusChange method.  There might also
have to be some filtering to ensure that only errors go through (similar to what
nsWebBrowserPersist::OnStatus does).

Wouldn't we also have to hook into nsIStreamListener methods for OnStopRequest
notifications (with mapping to OnStateChange)?

Maybe another approach would be to write a generalized wrapper class that
implements nsIWebProgressListener around a nsIProgressEventSink and
nsIStreamListener?
>Maybe another approach would be to write a generalized wrapper class that
implements nsIWebProgressListener around a nsIProgressEventSink and
nsIStreamListener?

Yes.  that is the best thing to do.  An adaptor class.  Are you up to do this?
The only problem is that, we could not use your interface directly. :-(

OK, maybe the adapter isn't worth the trouble.  But I still don't have time to
deal with this, unless you get it marked nsbeta1+ and added to my mozilla1.0 bug
list.
Charlie is interested in this, too.  Maybe he can help out?
QA Contact: mdunn → depstein
-> law
Assignee: valeski → law
-> me
-> me
Assignee: law → varga
QA Contact: depstein → carosendahl
i'm going to mark this WONTFIX based on the fact that it is easy enough to use
nsIWebBrowserPersist + nsIProgressDialog to achieve the effect.  if someone
really wants this, then please speak up ;-)
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → WONTFIX
(In reply to comment #10)
> i'm going to mark this WONTFIX based on the fact that it is easy enough to use
> nsIWebBrowserPersist + nsIProgressDialog to achieve the effect.  if someone
> really wants this, then please speak up ;-)

well... you actually implemented nsIInterfaceRequestor on it...
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.