Cant use ProgressDialog directly with nsIChannel's

RESOLVED WONTFIX

Status

()

Core
Embedding: APIs
RESOLVED WONTFIX
16 years ago
14 years ago

People

(Reporter: dougt, Assigned: janv)

Tracking

Trunk
x86
Windows 2000
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

16 years ago
To make the progress dialog easier to use by the nsIChannels, it should
implement the following interfaces:


nsIProgressEventSink
nsIInterfaceRequestor

In this way, the progress dialog can be opened and directly attached to a channel.
(Reporter)

Comment 1

16 years ago
Created attachment 71760 [details] [diff] [review]
Impl. my suggestions
(Reporter)

Updated

16 years ago
Blocks: 24867

Comment 2

16 years ago
Doug, I think this is a worthwhile extension.

Questions: 

What about handling errors that come through onStatus?  Presumably, those would
need to be translated into calls to the onStatusChange method.  There might also
have to be some filtering to ensure that only errors go through (similar to what
nsWebBrowserPersist::OnStatus does).

Wouldn't we also have to hook into nsIStreamListener methods for OnStopRequest
notifications (with mapping to OnStateChange)?

Maybe another approach would be to write a generalized wrapper class that
implements nsIWebProgressListener around a nsIProgressEventSink and
nsIStreamListener?
(Reporter)

Comment 3

16 years ago
>Maybe another approach would be to write a generalized wrapper class that
implements nsIWebProgressListener around a nsIProgressEventSink and
nsIStreamListener?

Yes.  that is the best thing to do.  An adaptor class.  Are you up to do this?
(Reporter)

Comment 4

16 years ago
The only problem is that, we could not use your interface directly. :-(

Comment 5

16 years ago
OK, maybe the adapter isn't worth the trouble.  But I still don't have time to
deal with this, unless you get it marked nsbeta1+ and added to my mozilla1.0 bug
list.

Comment 6

16 years ago
Charlie is interested in this, too.  Maybe he can help out?

Updated

16 years ago
QA Contact: mdunn → depstein

Comment 7

16 years ago
-> law
Assignee: valeski → law
(Assignee)

Comment 8

16 years ago
-> me
(Assignee)

Comment 9

16 years ago
-> me
Assignee: law → varga

Updated

16 years ago
QA Contact: depstein → carosendahl

Comment 10

14 years ago
i'm going to mark this WONTFIX based on the fact that it is easy enough to use
nsIWebBrowserPersist + nsIProgressDialog to achieve the effect.  if someone
really wants this, then please speak up ;-)
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → WONTFIX
(In reply to comment #10)
> i'm going to mark this WONTFIX based on the fact that it is easy enough to use
> nsIWebBrowserPersist + nsIProgressDialog to achieve the effect.  if someone
> really wants this, then please speak up ;-)

well... you actually implemented nsIInterfaceRequestor on it...
You need to log in before you can comment on or make changes to this bug.