Closed
Bug 1281489
Opened 8 years ago
Closed 8 years ago
Reps: Grips rep renders only 3 properties in long mode
Categories
(DevTools :: Shared Components, defect, P1)
DevTools
Shared Components
Tracking
(firefox50 fixed)
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: Honza, Assigned: Honza)
References
Details
(Whiteboard: [devtools-html])
Attachments
(1 file, 2 obsolete files)
|
6.46 KB,
patch
|
Honza
:
review+
|
Details | Diff | Splinter Review |
Follow up for bug 1264685. Grip rep should render 100 (max) properties in the long mode. It's rendering just 3. The longIterator should be used in Grip.render method in case this.props.mode == "long" Honza
|
||
Updated•8 years ago
|
Blocks: devtools-html-2
Whiteboard: [devtools-html] [triage]
|
|
||
Updated•8 years ago
|
Assignee: nobody → odvarko
Status: NEW → ASSIGNED
Iteration: --- → 50.2
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [devtools-html] [triage] → [devtools-html]
|
Assignee | |
Comment 1•8 years ago
|
||
Long mode in the grip + the grip test fixed. I am not sure how to text max number of props for the long mode. The grip stub could be pretty huge (> 100 props). Should we generate the `ownProperties` field? Honza
Attachment #8764611 -
Flags: review?(lclark)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8764611 [details] [diff] [review] bug1281489.patch Review of attachment 8764611 [details] [diff] [review]: ----------------------------------------------------------------- So far this looks good to me. I think generating the ownProperties field makes sense. Clearing the review for now, pending the test update.
Attachment #8764611 -
Flags: review?(lclark)
|
|
Assignee | |
Comment 3•8 years ago
|
||
(In reply to Lin Clark [:linclark] from comment #2) > I think generating the ownProperties field makes sense. Done Honza
Attachment #8764611 -
Attachment is obsolete: true
Attachment #8764887 -
Flags: review?(lclark)
|
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8764887 [details] [diff] [review] bug1281489.patch Review of attachment 8764887 [details] [diff] [review]: ----------------------------------------------------------------- Other than one minor issue, this looks good to me! ::: devtools/client/shared/components/test/mochitest/test_reps_grip.html @@ +280,1 @@ > "ownPropertiesLength": 5, This should be changed to 101.
Attachment #8764887 -
Flags: review?(lclark) → review+
|
|
Assignee | |
Comment 5•8 years ago
|
||
(In reply to Lin Clark [:linclark] from comment #4) > This should be changed to 101. Good catch, fixed! Honza
Attachment #8764887 -
Attachment is obsolete: true
Attachment #8765422 -
Flags: review+
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/c0fb7d447b9d Fix Grip rep long mode. r=linclark
Keywords: checkin-needed
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c0fb7d447b9d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•