Un-expire or remove reader mode histogram probes

RESOLVED FIXED in Firefox 50

Status

()

Toolkit
Reader Mode
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Margaret, Assigned: Gijs)

Tracking

Trunk
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
The follow probes are expiring in Firefox 50:

* READER_MODE_DOWNLOAD_MS expires in version 50.0a1 (watched by mleibovic@mozilla.com) - Time (ms) to download a document to show in reader mode
* READER_MODE_DOWNLOAD_RESULT expires in version 50.0a1 (watched by mleibovic@mozilla.com) - The result of trying to download a document to show in reader view (0=Success, 1=Error XHR, 2=Error no document)
* READER_MODE_PARSE_RESULT expires in version 50.0a1 (watched by mleibovic@mozilla.com) - The result of trying to parse a document to show in reader view (0=Success, 1=Error too many elements, 2=Error in worker, 3=Error no article)
* READER_MODE_SERIALIZE_DOM_MS expires in version 50.0a1 (watched by mleibovic@mozilla.com) - Time (ms) to serialize a DOM to send to the reader worker
* READER_MODE_WORKER_PARSE_MS expires in version 50.0a1 (watched by mleibovic@mozilla.com) - Time (ms) for the reader worker to parse a document

In an email thread, Gijs proposed removing all of them except READER_MODE_PARSE_RESULT. That sounds fine to me.
I don't have a strong opinion here, but I'd suggest keeping both READER_MODE_PARSE_RESULT and READER_MODE_DOWNLOAD_RESULT as general quality/problem indicators. The time probes seem fine to let expire.
(In reply to Justin Dolske [:Dolske] from comment #1)
> I don't have a strong opinion here, but I'd suggest keeping both
> READER_MODE_PARSE_RESULT and READER_MODE_DOWNLOAD_RESULT as general
> quality/problem indicators. The time probes seem fine to let expire.

+1
(Assignee)

Comment 3

2 years ago
Created attachment 8764973 [details]
Bug 1281536 - remove reader mode telemetry that's out of date, extend two existing probes,

Review commit: https://reviewboard.mozilla.org/r/60544/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/60544/
Attachment #8764973 - Flags: review?(rweiss)
Attachment #8764973 - Flags: review?(margaret.leibovic)
(Assignee)

Updated

2 years ago
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
(Reporter)

Updated

2 years ago
Attachment #8764973 - Flags: review?(margaret.leibovic) → review+
(Reporter)

Comment 4

2 years ago
Comment on attachment 8764973 [details]
Bug 1281536 - remove reader mode telemetry that's out of date, extend two existing probes,

https://reviewboard.mozilla.org/r/60544/#review57680

::: toolkit/components/telemetry/Histograms.json:9596
(Diff revision 1)
> -    "n_buckets": 60,
> -    "description": "Time (ms) to download a document to show in reader mode"
> -  },
>    "READER_MODE_PARSE_RESULT" : {
> -    "expires_in_version": "50",
> +    "expires_in_version": "54",
>      "alert_emails": ["mleibovic@mozilla.com"],

I think we should update these emails to alert firefox-dev instead of my personal email account :)
(Assignee)

Updated

2 years ago
Attachment #8764973 - Flags: review?(rweiss) → review?(benjamin)

Updated

2 years ago
Attachment #8764973 - Flags: review?(benjamin) → review+

Comment 5

2 years ago
Comment on attachment 8764973 [details]
Bug 1281536 - remove reader mode telemetry that's out of date, extend two existing probes,

https://reviewboard.mozilla.org/r/60544/#review59428

::: toolkit/components/telemetry/Histograms.json:9602
(Diff revision 1)
>      "kind": "enumerated",
>      "n_values": 5,
>      "description": "The result of trying to parse a document to show in reader view (0=Success, 1=Error too many elements, 2=Error in worker, 3=Error no article)"
>    },
>    "READER_MODE_DOWNLOAD_RESULT" : {
> -    "expires_in_version": "50",
> +    "expires_in_version": "54",

Responding to the bug comment: there should be somebody in particular who is responsible for these probes, not just a mailng list. It's fine to also add the list to the email alerts.

Be aware, that the alerting mechanism only works properly for scalar values, so you should not expect alerts for changes here: if this is in fact valuable data, somebody should either be responsible for monitoring it on a regular (weekly?) basis, or developing a real alerting mechanism.

Comment 6

2 years ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/ec92630e4c63
remove reader mode telemetry that's out of date, extend two existing probes, r=margaret,data-r=bsmedberg
(Assignee)

Comment 7

2 years ago
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #5)
> Comment on attachment 8764973 [details]
> Bug 1281536 - remove reader mode telemetry that's out of date, extend two
> existing probes,
> 
> https://reviewboard.mozilla.org/r/60544/#review59428
> 
> ::: toolkit/components/telemetry/Histograms.json:9602
> (Diff revision 1)
> >      "kind": "enumerated",
> >      "n_values": 5,
> >      "description": "The result of trying to parse a document to show in reader view (0=Success, 1=Error too many elements, 2=Error in worker, 3=Error no article)"
> >    },
> >    "READER_MODE_DOWNLOAD_RESULT" : {
> > -    "expires_in_version": "50",
> > +    "expires_in_version": "54",
> 
> Responding to the bug comment: there should be somebody in particular who is
> responsible for these probes, not just a mailng list. It's fine to also add
> the list to the email alerts.

Swapped to gijs@ + firefox-dev.

> Be aware, that the alerting mechanism only works properly for scalar values,
> so you should not expect alerts for changes here: if this is in fact
> valuable data, somebody should either be responsible for monitoring it on a
> regular (weekly?) basis, or developing a real alerting mechanism.

Is there a bug tracking making this work in general? Seems like generally, changes in distribution should trigger alerts, not just for scalars. If there is no prospect of that happening I can look at doing something myself or finding a PM who can own looking at this every week, but it'd be nice if we can delegate this to machines in general...
Flags: needinfo?(benjamin)

Comment 8

2 years ago
Better alerting is on the longer-term roadmap for the data engineering team, but it's probably going to be at least three months; there's a bunch of core scheduling and validation work that needs to happen first to support a general solution.
Flags: needinfo?(benjamin)
(Assignee)

Updated

2 years ago
Priority: -- → P1

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ec92630e4c63
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.