1281708 - "Assertion failure: false" [@ mozilla::NrIceStunServer::ToNicerStunStruct]

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P2)

Description

[Jesse Ruderman]

Attachment: testcase

Assertion failure: false, at media/mtransport/nricectx.cpp:215

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Nils Ohlmeier [:drno]]

Attachment: Bug 1281708: remove assert for unknown stun server transports.

Review commit: https://reviewboard.mozilla.org/r/60352/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/60352/

Comment 3

[Nils Ohlmeier [:drno]]

It fails safely in case of an unknown transport. The only question is if we should try to provide a more useful error message in this case?

Comment 4

[Michael Froman [:mjf]]

Comment on attachment 8764531 [details]
Bug 1281708: remove assert for unknown stun server transports.

https://reviewboard.mozilla.org/r/60352/#review57258

::: media/mtransport/nricectx.cpp
(Diff revision 1)
>    if (transport_ == kNrIceTransportUdp) {
>      server->transport = IPPROTO_UDP;
>    } else if (transport_ == kNrIceTransportTcp) {
>      server->transport = IPPROTO_TCP;
>    } else {
> -    MOZ_ASSERT(false);

Maybe log what happened here?

Comment 5

[Nils Ohlmeier [:drno]]

Comment on attachment 8764531 [details]
Bug 1281708: remove assert for unknown stun server transports.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/60352/diff/1-2/

Comment 6

[Michael Froman [:mjf]]

https://reviewboard.mozilla.org/r/60352/#review57320

Looks good to me

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1367c5639844
remove assert for unknown stun server transports. r=mjf

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1367c5639844