Closed Bug 1281708 Opened 4 years ago Closed 4 years ago

"Assertion failure: false" [@ mozilla::NrIceStunServer::ToNicerStunStruct]

Categories

(Core :: WebRTC: Networking, defect, P2, critical)

defect

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed
Blocking Flags:

People

(Reporter: jruderman, Assigned: drno)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, testcase)

Attachments

(3 files)

Attached file testcase
Assertion failure: false, at media/mtransport/nricectx.cpp:215
Attached file stack
Assignee: nobody → drno
backlog: --- → webrtc/webaudio+
Rank: 25
Priority: -- → P2
It fails safely in case of an unknown transport. The only question is if we should try to provide a more useful error message in this case?
Attachment #8764531 - Flags: review?(mfroman) → review+
Comment on attachment 8764531 [details]
Bug 1281708: remove assert for unknown stun server transports.

https://reviewboard.mozilla.org/r/60352/#review57258

::: media/mtransport/nricectx.cpp
(Diff revision 1)
>    if (transport_ == kNrIceTransportUdp) {
>      server->transport = IPPROTO_UDP;
>    } else if (transport_ == kNrIceTransportTcp) {
>      server->transport = IPPROTO_TCP;
>    } else {
> -    MOZ_ASSERT(false);

Maybe log what happened here?
Comment on attachment 8764531 [details]
Bug 1281708: remove assert for unknown stun server transports.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/60352/diff/1-2/
Pushed by drno@ohlmeier.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1367c5639844
remove assert for unknown stun server transports. r=mjf
https://hg.mozilla.org/mozilla-central/rev/1367c5639844
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.