Closed Bug 1281760 Opened 8 years ago Closed 8 years ago

Handle all errors thrown by bookmark merging and syncing and report as warnings not failures in sync status

Categories

(Firefox for iOS :: Sync, defect)

Product:
Firefox for iOS
Component:
Sync
Platform:
Other
iOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
fxios-v5.0 --- fixed
fxios-v6.0 --- fixed
fxios 5.0+ ---

People

(Reporter: fluffyemily, Assigned: fluffyemily)

References

Details

(Whiteboard: [target 5.0])

Attachments

(1 file)

Pull request
48 bytes, text/x-github-pull-request
sleroux
: review+
Details | Review 
Currently we are only catching BookmarkMergeErrors as warnings and reporting all other errors as sync failures. However, bookmark sync can also throw DatabaseErrors which are currently being reporter incorrectly. 

DatabaseErrors with messages that come from the BufferInconsistency enum are thrown by SQLiteBookmarksSyncing. These should be caught and reported as warnings.
Attached file Pull request — 

        Attachment #8764544 -
        Flags: review?(sleroux)

    
    

    
  
Comment on attachment 8764544 [details] [review]
Pull request

LGTM!

        Attachment #8764544 -
        Flags: review?(sleroux) → review+

    
    

    
  
merged master https://github.com/mozilla/firefox-ios/commit/222e78a461218bb58eb343bbe785eed23f7c9c16
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [target 5.0][needsuplift]

    
    

    
  
v5.x a2b2e94

          status-fxios-v5.0:
          affected → fixed

          status-fxios-v6.0:
          --- → fixed
Whiteboard: [target 5.0][needsuplift] → [target 5.0]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: