Closed Bug 1281762 Opened 3 years ago Closed 3 years ago

nsWindowRoot::mPopupNode may keep otherwise closed documents alive

Categories

(Core :: DOM: Core & HTML, defect)

36 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox48 --- fixed
firefox49 --- fixed
firefox50 --- fixed

People

(Reporter: smaug, Assigned: smaug)

References

Details

(Whiteboard: btpp-active)

Attachments

(1 file)

I think we could make mPopupNode a weak ref
Attached patch patchSplinter Review
https://treeherder.mozilla.org/#/jobs?repo=try&revision=feffa0b2ee8e
Assignee: nobody → bugs
Attachment #8764566 - Flags: review?(enndeakin)
Attachment #8764566 - Flags: review?(enndeakin) → review+
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8a1a3f39c99b
nsWindowRoot::mPopupNode may keep otherwise closed documents alive, r=enn
Comment on attachment 8764566 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: For e10s, bug 1058712 
[User impact if declined]: higher memory consumption and slower cycle collections in some cases
[Describe test coverage new/current, TreeHerder]: NA
[Risks and why]: should be very safe. 
[String/UUID change made/needed]: NA
Attachment #8764566 - Flags: approval-mozilla-beta?
Attachment #8764566 - Flags: approval-mozilla-aurora?
Whiteboard: btpp-active
https://hg.mozilla.org/mozilla-central/rev/8a1a3f39c99b
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Comment on attachment 8764566 [details] [diff] [review]
patch

Improve the memory usage, taking it.
Should be in 48 beta 4
Attachment #8764566 - Flags: approval-mozilla-beta?
Attachment #8764566 - Flags: approval-mozilla-beta+
Attachment #8764566 - Flags: approval-mozilla-aurora?
Attachment #8764566 - Flags: approval-mozilla-aurora+
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.