nsWindowRoot::mPopupNode may keep otherwise closed documents alive

RESOLVED FIXED in Firefox 48

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

36 Branch
mozilla50
Points:
---

Firefox Tracking Flags

(firefox48 fixed, firefox49 fixed, firefox50 fixed)

Details

(Whiteboard: btpp-active)

Attachments

(1 attachment)

(Assignee)

Comment 1

2 years ago
I think we could make mPopupNode a weak ref
(Assignee)

Comment 2

2 years ago
Created attachment 8764566 [details] [diff] [review]
patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=feffa0b2ee8e
Assignee: nobody → bugs
Attachment #8764566 - Flags: review?(enndeakin)

Updated

2 years ago
Attachment #8764566 - Flags: review?(enndeakin) → review+

Comment 3

2 years ago
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8a1a3f39c99b
nsWindowRoot::mPopupNode may keep otherwise closed documents alive, r=enn
(Assignee)

Comment 4

2 years ago
Comment on attachment 8764566 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: For e10s, bug 1058712 
[User impact if declined]: higher memory consumption and slower cycle collections in some cases
[Describe test coverage new/current, TreeHerder]: NA
[Risks and why]: should be very safe. 
[String/UUID change made/needed]: NA
Attachment #8764566 - Flags: approval-mozilla-beta?
Attachment #8764566 - Flags: approval-mozilla-aurora?
Whiteboard: btpp-active

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8a1a3f39c99b
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50

Updated

2 years ago
status-firefox48: --- → affected
status-firefox49: --- → affected
Comment on attachment 8764566 [details] [diff] [review]
patch

Improve the memory usage, taking it.
Should be in 48 beta 4
Attachment #8764566 - Flags: approval-mozilla-beta?
Attachment #8764566 - Flags: approval-mozilla-beta+
Attachment #8764566 - Flags: approval-mozilla-aurora?
Attachment #8764566 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.