Closed Bug 1281823 (webext-port-avast-online-security) Opened 5 years ago Closed 4 years ago

Enable Avast Online Security Chrome extension to work with Firefox

Categories

(WebExtensions :: Compatibility, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bsilverberg, Unassigned)

References

Details

(Whiteboard: [popular chrome extensions]triaged[awe:wrc@avast.com])

Chrome extension at https://chrome.google.com/webstore/detail/avast-online-security/gomekmidlodglbbmalcneegieacbdmki
Test uploaded to AMO at https://addons.allizom.org/en-US/firefox/addon/avast-online-security-ica-test/

Missing APIs:
- chrome.runtime.onInstalled (Bug 1252871)
- chrome.management (more research needed to determine which parts)
- chrome.extension.onMessageExternal (Bug 1258360)
Component: Untriaged → WebExtensions
Product: Firefox → Toolkit
Blocks: 1280062
Alias: webext-port-avast-online-security
Having grepped the full source code, here is a list of missing APIs:
- chrome.app.getDetails
- chrome.extension.connect (not documented in Chrome)
- chrome.extension.onConnect (not documented in Chrome)
- chrome.tabs.onSelectionChanged

Also, the various calls to chrome.management in the codebase are all commented out, as well as the call to chrome.extension.onMessageExternal.

After a bit of digging it looks like the extension code itself aliases extension.connect and onConnect to runtime (https://gist.github.com/bobsilverberg/cb1529a0d4cfcb4890eeefe5efe29802).
No longer depends on: 1258360
(In reply to Bob Silverberg [:bsilverberg] from comment #1)
> Having grepped the full source code, here is a list of missing APIs:
> - chrome.app.getDetails
> - chrome.extension.connect (not documented in Chrome)
> - chrome.extension.onConnect (not documented in Chrome)
> - chrome.tabs.onSelectionChanged (deprecated in favour of tabs.onActivated)
> 
> Also, the various calls to chrome.management in the codebase are all
> commented out, as well as the call to chrome.extension.onMessageExternal.
> 
> After a bit of digging it looks like the extension code itself aliases
> extension.connect and onConnect to runtime
> (https://gist.github.com/bobsilverberg/cb1529a0d4cfcb4890eeefe5efe29802).
Component: WebExtensions: Untriaged → WebExtensions: Compatibility
Priority: -- → P3
Based on comment 1 and the lack of blocking bugs, looks like this is done and closing. If anyone does more testing and finds more bugs, please comment or re-open.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Adding tag so this bug appears on https://arewewebextensionsyet.com/
Whiteboard: [popular chrome extensions]triaged → [popular chrome extensions]triaged[awe:wrc@avast.com]
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.