1281888 - The closed caption button should appear if there are 'captions' tracks

Status: RESOLVED FIXED

(Toolkit :: Video/Audio Controls, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

From bug 887934 comment 123:

"subtitles": Transcription or translation of the dialogue, suitable for when the sound is available but not understood (e.g. because the user does not understand the language of the media resource's audio track). Overlaid on the video.
"captions": Transcription or translation of the dialogue, sound effects, relevant musical cues, and other relevant audio information, suitable for when sound is unavailable or not clearly audible (e.g. because it is muted, drowned-out by ambient noise, or because the user is deaf). Overlaid on the video; labeled as appropriate for the hard-of-hearing.
https://www.w3.org/TR/html5/embedded-content-0.html#attr-track-kind

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1281888 - The closed caption button should appear if there are 'captions' tracks.

Review commit: https://reviewboard.mozilla.org/r/60420/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/60420/

Comment 2

[Ray Lin[:ralin]]

Comment on attachment 8764714 [details]
Bug 1281888 - The closed caption button should appear if there are 'captions' tracks.

https://reviewboard.mozilla.org/r/60420/#review57364

Looks good! Thanks for you help.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/d69c52dd4f67
The closed caption button should appear if there are 'captions' tracks. r=ralin

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d69c52dd4f67