Closed
Bug 1281932
Opened 9 years ago
Closed 9 years ago
Intermittent dom/u2f/tests/test_frame.html | Test timed out.
Categories
(Core :: DOM: Core & HTML, defect, P3)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla52
People
(Reporter: intermittent-bug-filer, Assigned: jcj)
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
Comment 1•9 years ago
|
||
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3
Comment hidden (mozreview-request) |
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jjones
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•9 years ago
|
||
Try run looks OK: https://treeherder.mozilla.org/#/jobs?repo=try&revision=93590064e39f
![]() |
||
Comment 4•9 years ago
|
||
mozreview-review |
Comment on attachment 8799059 [details]
Bug 1281932 - Fix intermittent u2f tests
https://reviewboard.mozilla.org/r/84354/#review83230
Ok - lgtm.
::: dom/u2f/tests/mochitest.ini:2
(Diff revision 1)
> [DEFAULT]
> support-files =
My assumption would be that support-files should be sorted, but it's probably not a big deal
::: dom/u2f/tests/test_appid_facet.html:26
(Diff revision 1)
> +
> +SpecialPowers.pushPrefEnv({"set": [["security.webauth.u2f", true],
> + ["security.webauth.u2f_enable_softtoken", true],
> + ["security.webauth.u2f_enable_usbtoken", false]]},
> +function() {
> + // listen for a messages from the mixed content test harness
nit: this comment appears to be a bit outdated at this point (same in all of the changed test_* files)
::: dom/u2f/tests/frame_appid_facet.html:14
(Diff revision 1)
> "use strict";
>
> +var countCompletions = 0;
> +var expectedCompletions = 5;
> +
> +function completed() {
Seems like completed could be defined in u2futil.js.
::: dom/u2f/tests/frame_appid_facet.html:16
(Diff revision 1)
> +var countCompletions = 0;
> +var expectedCompletions = 5;
> +
> +function completed() {
> + countCompletions += 1
> + if (countCompletions == expectedCompletions) {
It might be good to note a test failure if ever countCompletions > expectedCompletions.
::: dom/u2f/tests/u2futil.js:3
(Diff revision 1)
> +function handleEventMessage(event) {
> + if ("test" in event.data) {
> + var summary = event.data.test + ": " + event.data.msg;
nit: s/var/let/ here
::: dom/u2f/tests/u2futil.js:8
(Diff revision 1)
> + var summary = event.data.test + ": " + event.data.msg;
> + log(event.data.status + ": " + summary);
> + ok(event.data.status, summary);
> + } else if ("done" in event.data) {
> + SimpleTest.finish();
> + }
else indicate a test failure?
::: dom/u2f/tests/u2futil.js:11
(Diff revision 1)
> + } else if ("done" in event.data) {
> + SimpleTest.finish();
> + }
> + }
> +
> +function log(msg) {
console.log might be more helpful ultimately (or maybe in addition?)
Attachment #8799059 -
Flags: review?(dkeeler) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•9 years ago
|
||
mozreview-review |
Comment on attachment 8799059 [details]
Bug 1281932 - Fix intermittent u2f tests
https://reviewboard.mozilla.org/r/84354/#review83286
Assignee | ||
Comment 7•9 years ago
|
||
mozreview-review-reply |
Comment on attachment 8799059 [details]
Bug 1281932 - Fix intermittent u2f tests
https://reviewboard.mozilla.org/r/84354/#review83230
> Seems like completed could be defined in u2futil.js.
Yeah, I was lazy. :) Added `local_addTest` and `local_completeTest` to `u2futil.js` in patch 2.
> nit: s/var/let/ here
Thanks. I fixed this throughout `u2futil.js`.
> else indicate a test failure?
Good idea.
> console.log might be more helpful ultimately (or maybe in addition?)
Tossed it in there.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 9•9 years ago
|
||
Second try run looks quite good. Marking checkin-needed.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a6bd83dd40a3&selectedJob=28926054
Keywords: checkin-needed
Comment 10•9 years ago
|
||
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c1477dd6413c
Fix intermittent u2f tests r=keeler
Keywords: checkin-needed
Comment 11•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Updated•9 years ago
|
status-firefox50:
--- → affected
status-firefox51:
--- → affected
Whiteboard: [checkin-needed-aurora][checkin-needed-beta]
Comment 12•9 years ago
|
||
bugherder uplift |
Whiteboard: [checkin-needed-aurora][checkin-needed-beta] → [checkin-needed-beta]
Comment 13•9 years ago
|
||
bugherder uplift |
Whiteboard: [checkin-needed-beta]
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•