Closed Bug 1281932 Opened 9 years ago Closed 9 years ago

Intermittent dom/u2f/tests/test_frame.html | Test timed out.

Categories

(Core :: DOM: Core & HTML, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox50 --- fixed
firefox51 --- fixed
firefox52 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: jcj)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3
Assignee: nobody → jjones
Status: NEW → ASSIGNED
Comment on attachment 8799059 [details] Bug 1281932 - Fix intermittent u2f tests https://reviewboard.mozilla.org/r/84354/#review83230 Ok - lgtm. ::: dom/u2f/tests/mochitest.ini:2 (Diff revision 1) > [DEFAULT] > support-files = My assumption would be that support-files should be sorted, but it's probably not a big deal ::: dom/u2f/tests/test_appid_facet.html:26 (Diff revision 1) > + > +SpecialPowers.pushPrefEnv({"set": [["security.webauth.u2f", true], > + ["security.webauth.u2f_enable_softtoken", true], > + ["security.webauth.u2f_enable_usbtoken", false]]}, > +function() { > + // listen for a messages from the mixed content test harness nit: this comment appears to be a bit outdated at this point (same in all of the changed test_* files) ::: dom/u2f/tests/frame_appid_facet.html:14 (Diff revision 1) > "use strict"; > > +var countCompletions = 0; > +var expectedCompletions = 5; > + > +function completed() { Seems like completed could be defined in u2futil.js. ::: dom/u2f/tests/frame_appid_facet.html:16 (Diff revision 1) > +var countCompletions = 0; > +var expectedCompletions = 5; > + > +function completed() { > + countCompletions += 1 > + if (countCompletions == expectedCompletions) { It might be good to note a test failure if ever countCompletions > expectedCompletions. ::: dom/u2f/tests/u2futil.js:3 (Diff revision 1) > +function handleEventMessage(event) { > + if ("test" in event.data) { > + var summary = event.data.test + ": " + event.data.msg; nit: s/var/let/ here ::: dom/u2f/tests/u2futil.js:8 (Diff revision 1) > + var summary = event.data.test + ": " + event.data.msg; > + log(event.data.status + ": " + summary); > + ok(event.data.status, summary); > + } else if ("done" in event.data) { > + SimpleTest.finish(); > + } else indicate a test failure? ::: dom/u2f/tests/u2futil.js:11 (Diff revision 1) > + } else if ("done" in event.data) { > + SimpleTest.finish(); > + } > + } > + > +function log(msg) { console.log might be more helpful ultimately (or maybe in addition?)
Attachment #8799059 - Flags: review?(dkeeler) → review+
Comment on attachment 8799059 [details] Bug 1281932 - Fix intermittent u2f tests https://reviewboard.mozilla.org/r/84354/#review83230 > Seems like completed could be defined in u2futil.js. Yeah, I was lazy. :) Added `local_addTest` and `local_completeTest` to `u2futil.js` in patch 2. > nit: s/var/let/ here Thanks. I fixed this throughout `u2futil.js`. > else indicate a test failure? Good idea. > console.log might be more helpful ultimately (or maybe in addition?) Tossed it in there.
Keywords: checkin-needed
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Whiteboard: [checkin-needed-aurora][checkin-needed-beta]
Whiteboard: [checkin-needed-aurora][checkin-needed-beta] → [checkin-needed-beta]
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: