1281937 - Error message when try push fails due to permission error is misleading

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Josh Matthews [:jdm]]

Attachment: Console output

I used `./mach try` when pushing from a computer with an older SSH key on it. The error message I received from try led me to believe that I was missing the push-to-try extension, which sent me on a wild goose chase of getting ./mach mercurial-setup to run (see the final lines of the attached console output). We should more careful about identifying the cause of the failure to push before making unhelpful suggestions.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1281937 - Provide a more helpful error message when `./mach try` fails to push to try.

Review commit: https://reviewboard.mozilla.org/r/60428/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/60428/

Comment 2

[Josh Matthews [:jdm]]

https://reviewboard.mozilla.org/r/60428/#review57340

::: testing/tools/autotry/autotry.py:559
(Diff revision 1)
> -                print('The "push-to-try" hg extension is required to push from '
> -                      'hg to try with the autotry command.\n\nIt can be installed '
> -                      'to Mercurial 3.3 or above by running ./mach mercurial-setup')
> +                print('\nmach failed to push to try. There may be a problem '
> +                      'with your ssh key, or another issue with your mercurial '
> +                      'installation. Note that the "push-to-try" hg extension '
> +                      'is required. If this extension is not present, it can '
> +                      'be installed to Mercurial 3.3 or above by running '
> +                      './mach mercurial-setup')

Could we detect if push-to-try is installed and only display this part if it's actually necessary?

Comment 3

[Josh Matthews [:jdm]]

Comment on attachment 8764736 [details]
Bug 1281937 - Provide a more helpful error message when `./mach try` fails to push to try.

https://reviewboard.mozilla.org/r/60428/#review57922

Comment 4

[Chris Manchester (limited bugmail, email directly)]

r- without comments, can you elaborate?

Comment 5

[Josh Matthews [:jdm]]

I left a comment on reviewboard; it was closed, and then I reopened it because it does not appear to have been addressed.

Comment 6

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8764736 [details]
Bug 1281937 - Provide a more helpful error message when `./mach try` fails to push to try.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/60428/diff/1-2/

Comment 7

[Chris Manchester (limited bugmail, email directly)]

Aha, my mistake. I pushed a new revision and marked the issue as fixed, I missed the step of publishing the new review request.

Comment 8

[Josh Matthews [:jdm]]

Comment on attachment 8764736 [details]
Bug 1281937 - Provide a more helpful error message when `./mach try` fails to push to try.

https://reviewboard.mozilla.org/r/60428/#review57982

Much better!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dad76327ba83
Provide a more helpful error message when `./mach try` fails to push to try. r=jdm

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dad76327ba83