1281961 - WasmBaselineCompile fails to compile on non-ion platform

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Steve Singer (:stevensn)]

On ppc64 (non-ion)

WasmBaselineCompile.cpp:1031:17: error: ‘ScratchRegisterScope’ was not declared

JS_PUNBOX64 is defined on 64 bit platforms that aren't supported by WarmBaselineCompile (non-ion, maybe mips64 ?)

Comment 1

[Cameron Kaiser [:spectre]]

Lars, what's the easiest way around this?

Comment 2

[Steve Singer (:stevensn)]

Attachment: 1281961.diff

Comment 3

[Lars T Hansen [:lth]]

I think the easiest way forward - for now - is to do for PPC64 what I do for ARM64 up at the top of WasmBaselineCompile.cpp, and just define a dummy ScratchRegisterScope for the platform so that this code will compile.

The guard in BaselineCanCompile() down at the bottom of the file will ensure that this compiler is never invoked on PPC64, so it's OK to have a dummy implementation that just allows compilation to proceed - that's the situation for ARM64 as well.

I believe that it's not necessary for JS_PUNBOX64 to be defined on PPC64, with that fix in place, but do let me know if that turns out not to be the case.

Comment 4

[Lars T Hansen [:lth]]

Comment on attachment 8764782 [details] [diff] [review]
1281961.diff

Review of attachment 8764782 [details] [diff] [review]:
-----------------------------------------------------------------

Clearing r? for now, see my other comment about a better way to fix this.

Comment 5

[Lars T Hansen [:lth]]

Also, there's a patch coming on bug 1277008 to clean up scratch register handling further.

Comment 6

[Lars T Hansen [:lth]]

I have been testing this and it compiles on various platforms with Ion disabled (notably on arm64 which should be similar to ppc64) -- there's a more general solution now.  Please close this ticket if you find that the current code suits your needs.

Comment 7

[Steve Singer (:stevensn)]

WasmBaselineCompile now builds on ppc

Thanks