Closed Bug 1281963 Opened 3 years ago Closed 3 years ago

Hide navigator.plugins and navigator.mimeTypes when resisting fingerprinting (Tor 17207)

Categories

(Core :: Plug-ins, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: arthur, Assigned: huseby)

References

(Blocks 1 open bug)

Details

(Whiteboard: [tor][fingerprinting])

Attachments

(1 file, 2 obsolete files)

In Tor Browser, we introduced a patch that hides the contents of navigator.plugins and navigator.mimeTypes when Firefox's "privacy.resistFingerprinting" pref is enabled. We would like to propose upstreaming this patch.

See https://trac.torproject.org/17207
Here is the patch rebased to the latest mozilla-central. Includes mochitests.

Try results: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ffedf1fa05c5

(This patch differs from those in bug 757726 in that it is only active when the "privacy.resistFingerprinting" pref is enabled.)
Assignee: nobody → arthuredelstein
Status: NEW → ASSIGNED
Attachment #8764941 - Flags: review?(john)
Comment on attachment 8764941 [details] [diff] [review]
0001-Bug-1281963-Hide-mime-types-and-plugins-when-resisti.patch

I'm going to ask blassey to review this to integrate/merge it with his work. I have no problem with this in theory.
Attachment #8764941 - Flags: review?(john) → review?(blassey.bugs)
Priority: -- → P3
I'll take it.  This patch is part of the Tor Uplift project we're doing right now.  See this: https://wiki.mozilla.org/Security/Tor_Uplift/Tracking  This is actually a P1 for the project.  Thanks.
Assignee: arthuredelstein → huseby
Flags: needinfo?(benjamin)
Blocks: meta_tor
Priority: P3 → P1
Brad, we're pushing hard to land as many Tor patches as we can as fast as we can.  Will you please review this patch ASAP?  Thanks!
Flags: needinfo?(blassey.bugs)
Flags: needinfo?(benjamin)
Attachment #8764941 - Flags: review?(blassey.bugs) → review+
Flags: needinfo?(blassey.bugs)
Keywords: checkin-needed
(Thanks for the review, Brad!)
needs rebasing 

applying 0001-Bug-1281963-Hide-mime-types-and-plugins-when-resisti.patch
patching file dom/base/test/mochitest.ini
Hunk #1 FAILED at 663
1 out of 1 hunks FAILED -- saving rejects to file dom/base/test/mochitest.ini.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh 0001-Bug-1281963-Hide-mime-types-and-plugins-when-resisti.patch
Flags: needinfo?(huseby)
Keywords: checkin-needed
Rebased to latest mozilla-central.
Attachment #8764941 - Attachment is obsolete: true
Keywords: checkin-needed
Flags: needinfo?(huseby)
Hi Artur, 

there seems to be a new conflict like :

Hunk #1 FAILED at 18
1 out of 5 hunks FAILED -- saving rejects to file dom/base/nsPluginArray.cpp.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh 0001-Bug-1281963-Hide-mime-types-and-plugins-when-resisti.patch

could you take a look ? thanks!
Flags: needinfo?(arthuredelstein)
Keywords: checkin-needed
Bitrotted the same day by https://hg.mozilla.org/mozilla-central/rev/776f0bb21587 ;)

Here's the new version, again rebased to the latest mozilla-central.
Attachment #8766387 - Attachment is obsolete: true
Flags: needinfo?(arthuredelstein)
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dd2cdd266362
Hide mime types and plugins when resisting fingerprinting. r=blassey
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/dd2cdd266362
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Summary: Hide navigator.plugins and navigator.mimeTypes when resisting fingerprinting → Hide navigator.plugins and navigator.mimeTypes when resisting fingerprinting (Tor 17207)
Whiteboard: [tor] → [tor][fingerprinting]
Depends on: 1317846
You need to log in before you can comment on or make changes to this bug.