1281963 - Hide navigator.plugins and navigator.mimeTypes when resisting fingerprinting (Tor 17207)

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect, P1)

Description

[Arthur Edelstein [:arthur]]

In Tor Browser, we introduced a patch that hides the contents of navigator.plugins and navigator.mimeTypes when Firefox's "privacy.resistFingerprinting" pref is enabled. We would like to propose upstreaming this patch.

See https://trac.torproject.org/17207

Comment 1

[Arthur Edelstein [:arthur]]

Attachment: 0001-Bug-1281963-Hide-mime-types-and-plugins-when-resisti.patch

Here is the patch rebased to the latest mozilla-central. Includes mochitests.

Try results: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ffedf1fa05c5

(This patch differs from those in bug 757726 in that it is only active when the "privacy.resistFingerprinting" pref is enabled.)

Comment 2

[Benjamin Smedberg]

Comment on attachment 8764941 [details] [diff] [review]
0001-Bug-1281963-Hide-mime-types-and-plugins-when-resisti.patch

I'm going to ask blassey to review this to integrate/merge it with his work. I have no problem with this in theory.

Comment 3

[Dave Huseby [:huseby]]

I'll take it.  This patch is part of the Tor Uplift project we're doing right now.  See this: https://wiki.mozilla.org/Security/Tor_Uplift/Tracking  This is actually a P1 for the project.  Thanks.

Comment 4

[Dave Huseby [:huseby]]

Brad, we're pushing hard to land as many Tor patches as we can as fast as we can.  Will you please review this patch ASAP?  Thanks!

Comment 5

[Arthur Edelstein [:arthur]]

(Thanks for the review, Brad!)

Comment 6

[Carsten Book [:Tomcat]]

needs rebasing 

applying 0001-Bug-1281963-Hide-mime-types-and-plugins-when-resisti.patch
patching file dom/base/test/mochitest.ini
Hunk #1 FAILED at 663
1 out of 1 hunks FAILED -- saving rejects to file dom/base/test/mochitest.ini.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh 0001-Bug-1281963-Hide-mime-types-and-plugins-when-resisti.patch

Comment 7

[Arthur Edelstein [:arthur]]

Attachment: 0001-Bug-1281963-Hide-mime-types-and-plugins-when-resisti.patch

Rebased to latest mozilla-central.

Comment 8

[Carsten Book [:Tomcat]]

Hi Artur, 

there seems to be a new conflict like :

Hunk #1 FAILED at 18
1 out of 5 hunks FAILED -- saving rejects to file dom/base/nsPluginArray.cpp.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh 0001-Bug-1281963-Hide-mime-types-and-plugins-when-resisti.patch

could you take a look ? thanks!

Comment 9

[Arthur Edelstein [:arthur]]

Attachment: 0001-Bug-1281963-Hide-mime-types-and-plugins-when-resisti.patch

Bitrotted the same day by https://hg.mozilla.org/mozilla-central/rev/776f0bb21587 ;)

Here's the new version, again rebased to the latest mozilla-central.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dd2cdd266362
Hide mime types and plugins when resisting fingerprinting. r=blassey

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dd2cdd266362