1282109 - update version of kinto.js client to 3.1.2 (and kinto-http.js to 2.0.0)

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect, P2)

Description

[Ethan Glasser-Camp (:glasserc)]

Several changes to the kinto.js library have been made upstream. In particular, https://github.com/Kinto/kinto.js/pull/455, https://github.com/Kinto/kinto.js/pull/460, https://github.com/Kinto/kinto.js/pull/477, and https://github.com/Kinto/kinto.js/pull/478 are necessary to use kinto to implement chrome.storage.sync.

Comment 1

[Ethan Glasser-Camp (:glasserc)]

Attachment: Bug 1282109: update kinto-offline-client.js,

Review commit: https://reviewboard.mozilla.org/r/60552/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/60552/

Comment 2

[Ethan Glasser-Camp (:glasserc)]

Comment on attachment 8764982 [details]
Bug 1282109: update kinto-offline-client.js,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/60552/diff/1-2/

Comment 3

[Ethan Glasser-Camp (:glasserc)]

Comment on attachment 8764982 [details]
Bug 1282109: update kinto-offline-client.js,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/60552/diff/2-3/

Comment 4

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8764982 [details]
Bug 1282109: update kinto-offline-client.js,

Did you need me to review this, Ethan, or are you just flagging me because I need it to make the patch in bug 1253740 work?

Comment 5

[Ethan Glasser-Camp (:glasserc)]

(In reply to Bob Silverberg [:bsilverberg] from comment #4)
> Comment on attachment 8764982 [details]
> Bug 1282109: update kinto-offline-client.js,
> 
> Did you need me to review this, Ethan, or are you just flagging me because I
> need it to make the patch in bug 1253740 work?

I flagged you because I don't know what the review situation is for this code. It's already been reviewed once in the linked PRs, so what is the process for it to get into Gecko?

Comment 6

[Mathieu Leplatre [:leplatrem]]

https://reviewboard.mozilla.org/r/60552/#review58394

::: services/common/kinto-offline-client.js:2108
(Diff revision 3)
> +   * @return {Object}
> +   */
> +  cleanLocalFields(record) {
> +    const localKeys = RECORD_FIELDS_TO_CLEAN.concat(this.localFields);
> +    return (0, _utils.omitKeys)(record, localKeys);
> +  }

This new function allows us to get rid of this: https://dxr.mozilla.org/mozilla-central/rev/b69a5bbb5e40bd426e35222baa600b481e50d265/services/common/blocklist-clients.js#45

Comment 7

[Ethan Glasser-Camp (:glasserc)]

Comment on attachment 8764982 [details]
Bug 1282109: update kinto-offline-client.js,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/60552/diff/3-4/

Comment 8

[Ethan Glasser-Camp (:glasserc)]

I didn't realize there was also an http-client bundled with Gecko; the new version of the patch updates this as well.

Comment 9

[Bob Silverberg [:bsilverberg]]

(In reply to Ethan Glasser-Camp (:glasserc) from comment #5)
> (In reply to Bob Silverberg [:bsilverberg] from comment #4)
> > Comment on attachment 8764982 [details]
> > Bug 1282109: update kinto-offline-client.js,
> > 
> > Did you need me to review this, Ethan, or are you just flagging me because I
> > need it to make the patch in bug 1253740 work?
> 
> I flagged you because I don't know what the review situation is for this
> code. It's already been reviewed once in the linked PRs, so what is the
> process for it to get into Gecko?

Sorry, I have no idea.

Comment 10

[Ethan Glasser-Camp (:glasserc)]

Hi Mark, Tarek suggested that I should ask you about what the correct process is for updating the version of Kinto that we bundle in Gecko. Do you know, or can you give me the name of someone else to ask?

Comment 11

[Ethan Glasser-Camp (:glasserc)]

Better not look at this one yet. There's a bug in the underlying library that the Firefox tests uncovered. I've opened https://github.com/Kinto/kinto.js/pull/488 to address it.

Comment 12

[Ethan Glasser-Camp (:glasserc)]

Comment on attachment 8764982 [details]
Bug 1282109: update kinto-offline-client.js,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/60552/diff/4-5/

Comment 13

[Mark Goodwin [:mgoodwin]]

clearing ni? following conversation on IRC.

Comment 14

[Ethan Glasser-Camp (:glasserc)]

Hi MattN, mgoodwin said that in the past you have tended to review these kinds of updates. Is that right? leplatrem told me that you were busy lately and might not have time. In that case, is there someone else who can review them? Thanks!

Comment 15

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8764982 [details]
Bug 1282109: update kinto-offline-client.js,

Clearing my review request as I am not the person to review this.

Comment 16

[Matthew N. [:MattN]]

Comment on attachment 8764982 [details]
Bug 1282109: update kinto-offline-client.js,

https://reviewboard.mozilla.org/r/60552/#review60874

Comment 17

[Ethan Glasser-Camp (:glasserc)]

This is blocking on https://github.com/Kinto/kinto.js/issues/495.

Comment 18

[Ethan Glasser-Camp (:glasserc)]

Comment on attachment 8764982 [details]
Bug 1282109: update kinto-offline-client.js,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/60552/diff/5-6/

Comment 19

[Ethan Glasser-Camp (:glasserc)]

Comment on attachment 8764982 [details]
Bug 1282109: update kinto-offline-client.js,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/60552/diff/6-7/

Comment 20

[Ethan Glasser-Camp (:glasserc)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9c6362db4fbb

Comment 21

[Ethan Glasser-Camp (:glasserc)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ae3b32b315c

Comment 22

[Mark Goodwin [:mgoodwin]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/80b9e593a3aeddb2fade68ad88619b9b31d599d2
Bug 1282109: update kinto-offline-client.js, r=MattN

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/80b9e593a3ae
update kinto-offline-client.js, r=MattN

Comment 24

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/80b9e593a3ae