Closed Bug 1282109 Opened 4 years ago Closed 4 years ago

update version of kinto.js client to 3.1.2 (and kinto-http.js to 2.0.0)

Categories

(WebExtensions :: Untriaged, defect, P2)

defect

Tracking

(firefox50 fixed)

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: glasserc, Assigned: glasserc)

References

Details

(Whiteboard: [storage] triaged)

Attachments

(1 file)

Several changes to the kinto.js library have been made upstream. In particular, https://github.com/Kinto/kinto.js/pull/455, https://github.com/Kinto/kinto.js/pull/460, https://github.com/Kinto/kinto.js/pull/477, and https://github.com/Kinto/kinto.js/pull/478 are necessary to use kinto to implement chrome.storage.sync.
Assignee: nobody → eglassercamp
Blocks: 1253740
Priority: -- → P2
Whiteboard: [storage] triaged
Blocks: 1280877
Comment on attachment 8764982 [details]
Bug 1282109: update kinto-offline-client.js,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/60552/diff/1-2/
Comment on attachment 8764982 [details]
Bug 1282109: update kinto-offline-client.js,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/60552/diff/2-3/
Comment on attachment 8764982 [details]
Bug 1282109: update kinto-offline-client.js,

Did you need me to review this, Ethan, or are you just flagging me because I need it to make the patch in bug 1253740 work?
Flags: needinfo?(eglassercamp)
(In reply to Bob Silverberg [:bsilverberg] from comment #4)
> Comment on attachment 8764982 [details]
> Bug 1282109: update kinto-offline-client.js,
> 
> Did you need me to review this, Ethan, or are you just flagging me because I
> need it to make the patch in bug 1253740 work?

I flagged you because I don't know what the review situation is for this code. It's already been reviewed once in the linked PRs, so what is the process for it to get into Gecko?
Flags: needinfo?(eglassercamp)
https://reviewboard.mozilla.org/r/60552/#review58394

::: services/common/kinto-offline-client.js:2108
(Diff revision 3)
> +   * @return {Object}
> +   */
> +  cleanLocalFields(record) {
> +    const localKeys = RECORD_FIELDS_TO_CLEAN.concat(this.localFields);
> +    return (0, _utils.omitKeys)(record, localKeys);
> +  }

This new function allows us to get rid of this: https://dxr.mozilla.org/mozilla-central/rev/b69a5bbb5e40bd426e35222baa600b481e50d265/services/common/blocklist-clients.js#45
Comment on attachment 8764982 [details]
Bug 1282109: update kinto-offline-client.js,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/60552/diff/3-4/
I didn't realize there was also an http-client bundled with Gecko; the new version of the patch updates this as well.
(In reply to Ethan Glasser-Camp (:glasserc) from comment #5)
> (In reply to Bob Silverberg [:bsilverberg] from comment #4)
> > Comment on attachment 8764982 [details]
> > Bug 1282109: update kinto-offline-client.js,
> > 
> > Did you need me to review this, Ethan, or are you just flagging me because I
> > need it to make the patch in bug 1253740 work?
> 
> I flagged you because I don't know what the review situation is for this
> code. It's already been reviewed once in the linked PRs, so what is the
> process for it to get into Gecko?

Sorry, I have no idea.
Hi Mark, Tarek suggested that I should ask you about what the correct process is for updating the version of Kinto that we bundle in Gecko. Do you know, or can you give me the name of someone else to ask?
Flags: needinfo?(mgoodwin)
Better not look at this one yet. There's a bug in the underlying library that the Firefox tests uncovered. I've opened https://github.com/Kinto/kinto.js/pull/488 to address it.
Comment on attachment 8764982 [details]
Bug 1282109: update kinto-offline-client.js,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/60552/diff/4-5/
clearing ni? following conversation on IRC.
Flags: needinfo?(mgoodwin)
Hi MattN, mgoodwin said that in the past you have tended to review these kinds of updates. Is that right? leplatrem told me that you were busy lately and might not have time. In that case, is there someone else who can review them? Thanks!
Flags: needinfo?(MattN+bmo)
Summary: update version of kinto.js client → update version of kinto.js client to 3.1.1 (and kinto-http.js to 2.0.0)
Comment on attachment 8764982 [details]
Bug 1282109: update kinto-offline-client.js,

Clearing my review request as I am not the person to review this.
Attachment #8764982 - Flags: review?(bob.silverberg)
Attachment #8764982 - Flags: review+
Flags: needinfo?(MattN+bmo)
Comment on attachment 8764982 [details]
Bug 1282109: update kinto-offline-client.js,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/60552/diff/5-6/
Attachment #8764982 - Flags: review+ → review?(bob.silverberg)
Comment on attachment 8764982 [details]
Bug 1282109: update kinto-offline-client.js,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/60552/diff/6-7/
Attachment #8764982 - Flags: review?(bob.silverberg)
Summary: update version of kinto.js client to 3.1.1 (and kinto-http.js to 2.0.0) → update version of kinto.js client to 3.1.2 (and kinto-http.js to 2.0.0)
https://hg.mozilla.org/mozilla-central/rev/80b9e593a3ae
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.