Closed Bug 1282135 Opened 4 years ago Closed 4 years ago

Fix the interaction between MOZ_DEBUG and `--disable-debug`

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox50 fixed)

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: chmanchester, Assigned: chmanchester)

References

Details

Attachments

(1 file)

The fix for bug 1281603 exposes a hazard if someone builds with MOZ_DEBUG in the environment, but doesn't set --{enable,disable}-debug, because MOZ_DEBUG will end up set in the build environment, but other things keyed off of --enable-debug will not get set correctly.
As an effect of this patch, MOZ_DEBUG in the environment is not enough to
produce a debug build.

Review commit: https://reviewboard.mozilla.org/r/60566/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/60566/
Attachment #8765020 - Flags: review?(mh+mozilla)
Comment on attachment 8765020 [details]
Bug 1282135 - Require --enable-debug to produce a debug builds, and fix interaction with MOZ_DEBUG in the environment.

https://reviewboard.mozilla.org/r/60566/#review57772
Attachment #8765020 - Flags: review?(mh+mozilla) → review+
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1e4b0050e62a
Require --enable-debug to produce a debug builds, and fix interaction with MOZ_DEBUG in the environment. r=glandium
https://hg.mozilla.org/mozilla-central/rev/1e4b0050e62a
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.