Fix the interaction between MOZ_DEBUG and `--disable-debug`

RESOLVED FIXED in Firefox 50

Status

defect
RESOLVED FIXED
3 years ago
Last year

People

(Reporter: chmanchester, Assigned: chmanchester)

Tracking

unspecified
mozilla50
Dependency tree / graph

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(1 attachment)

The fix for bug 1281603 exposes a hazard if someone builds with MOZ_DEBUG in the environment, but doesn't set --{enable,disable}-debug, because MOZ_DEBUG will end up set in the build environment, but other things keyed off of --enable-debug will not get set correctly.
As an effect of this patch, MOZ_DEBUG in the environment is not enough to
produce a debug build.

Review commit: https://reviewboard.mozilla.org/r/60566/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/60566/
Attachment #8765020 - Flags: review?(mh+mozilla)
Comment on attachment 8765020 [details]
Bug 1282135 - Require --enable-debug to produce a debug builds, and fix interaction with MOZ_DEBUG in the environment.

https://reviewboard.mozilla.org/r/60566/#review57772
Attachment #8765020 - Flags: review?(mh+mozilla) → review+

Comment 3

3 years ago
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1e4b0050e62a
Require --enable-debug to produce a debug builds, and fix interaction with MOZ_DEBUG in the environment. r=glandium

Comment 4

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1e4b0050e62a
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50

Updated

Last year
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.