1282135 - Fix the interaction between MOZ_DEBUG and `--disable-debug`

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Chris Manchester (limited bugmail, email directly)]

The fix for bug 1281603 exposes a hazard if someone builds with MOZ_DEBUG in the environment, but doesn't set --{enable,disable}-debug, because MOZ_DEBUG will end up set in the build environment, but other things keyed off of --enable-debug will not get set correctly.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1282135 - Require --enable-debug to produce a debug builds, and fix interaction with MOZ_DEBUG in the environment.

As an effect of this patch, MOZ_DEBUG in the environment is not enough to
produce a debug build.

Review commit: https://reviewboard.mozilla.org/r/60566/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/60566/

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8765020 [details]
Bug 1282135 - Require --enable-debug to produce a debug builds, and fix interaction with MOZ_DEBUG in the environment.

https://reviewboard.mozilla.org/r/60566/#review57772

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1e4b0050e62a
Require --enable-debug to produce a debug builds, and fix interaction with MOZ_DEBUG in the environment. r=glandium

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1e4b0050e62a