Closed
Bug 1282211
Opened 8 years ago
Closed 8 years ago
Requests cannot be sorted by cause
Categories
(DevTools :: Netmonitor, defect, P2)
DevTools
Netmonitor
Tracking
(firefox50 fixed)
RESOLVED
FIXED
Firefox 50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: sjakthol, Assigned: jsnajdr)
Details
Attachments
(1 file)
5.96 KB,
patch
|
Honza
:
review+
|
Details | Diff | Splinter Review |
STR: 1. Open network monitor and reload this page 2. Click on the 'Cause' column header to sort the requests by cause What happens: Nothing. What should happen: The requests are sorted according to the cause. Relevant piece of code (case 'cause' missing): http://searchfox.org/mozilla-central/rev/970569ad57ac4436ff31aa2ac63f38ed3ee2932d/devtools/client/netmonitor/netmonitor-view.js#1198
Comment 1•8 years ago
|
||
Jarda, this sounds like a bug, can you please take a look at it? Honza
Flags: needinfo?(jsnajdr)
Priority: -- → P2
Assignee | ||
Comment 2•8 years ago
|
||
Fixed: - add support for sorting by cause - little code cleanup of the _byType function now that the line length limit is 90, not 80 - added sorting test to browser_net_cause.js
Attachment #8766301 -
Flags: review?(odvarko)
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(jsnajdr)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → jsnajdr
Assignee | ||
Comment 3•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fb76a19f1cea
Comment 4•8 years ago
|
||
Comment on attachment 8766301 [details] [diff] [review] Requests cannot be sorted by cause Review of attachment 8766301 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for quick patch, looks great to me, nothing I would change. (the test passes for me on my machine) The try looks also good. Honza
Attachment #8766301 -
Flags: review?(odvarko) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/3ab0235c289b Requests cannot be sorted by cause r=Honza
Keywords: checkin-needed
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3ab0235c289b
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Comment 7•8 years ago
|
||
I have reproduced this bug on Firefox nightly according to Fixing bug is verified on Latest Nightly--Build ID:(20160711034039),User Agent: Mozilla/5.0 (Windows NT 10.0; rv:50.0) Gecko/20100101 Firefox/50.0 Tested OS--Windows10 32bit
QA Whiteboard: [bugday-20160713]
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•