1282211 - Requests cannot be sorted by cause

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P2)

Description

[Sami Jaktholm]

STR:
1. Open network monitor and reload this page
2. Click on the 'Cause' column header to sort the requests by cause

What happens: Nothing.
What should happen: The requests are sorted according to the cause.

Relevant piece of code (case 'cause' missing): http://searchfox.org/mozilla-central/rev/970569ad57ac4436ff31aa2ac63f38ed3ee2932d/devtools/client/netmonitor/netmonitor-view.js#1198

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Jarda, this sounds like a bug, can you please take a look at it?

Honza

Comment 2

[Jarda Snajdr [:jsnajdr]]

Attachment: Requests cannot be sorted by cause

Fixed:
- add support for sorting by cause
- little code cleanup of the _byType function now that the line length limit is 90, not 80
- added sorting test to browser_net_cause.js

Comment 3

[Jarda Snajdr [:jsnajdr]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fb76a19f1cea

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8766301 [details] [diff] [review]
Requests cannot be sorted by cause

Review of attachment 8766301 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for quick patch, looks great to me, nothing I would change.
(the test passes for me on my machine)

The try looks also good.

Honza

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/3ab0235c289b
Requests cannot be sorted by cause r=Honza

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3ab0235c289b

Comment 7

[Saheda Reza [:Antora]]

I have reproduced this bug on Firefox nightly according to

Fixing bug is verified on Latest Nightly--Build ID:(20160711034039),User Agent: Mozilla/5.0 (Windows NT 10.0; rv:50.0) Gecko/20100101 Firefox/50.0


Tested OS--Windows10 32bit