Requests cannot be sorted by cause

RESOLVED FIXED in Firefox 50

Status

DevTools
Netmonitor
P2
normal
RESOLVED FIXED
2 years ago
a month ago

People

(Reporter: Sami Jaktholm, Assigned: jsnajdr)

Tracking

Trunk
Firefox 50

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
STR:
1. Open network monitor and reload this page
2. Click on the 'Cause' column header to sort the requests by cause

What happens: Nothing.
What should happen: The requests are sorted according to the cause.

Relevant piece of code (case 'cause' missing): http://searchfox.org/mozilla-central/rev/970569ad57ac4436ff31aa2ac63f38ed3ee2932d/devtools/client/netmonitor/netmonitor-view.js#1198
Jarda, this sounds like a bug, can you please take a look at it?

Honza
Flags: needinfo?(jsnajdr)
Priority: -- → P2
(Assignee)

Comment 2

2 years ago
Created attachment 8766301 [details] [diff] [review]
Requests cannot be sorted by cause

Fixed:
- add support for sorting by cause
- little code cleanup of the _byType function now that the line length limit is 90, not 80
- added sorting test to browser_net_cause.js
Attachment #8766301 - Flags: review?(odvarko)
(Assignee)

Updated

2 years ago
Flags: needinfo?(jsnajdr)
(Assignee)

Updated

2 years ago
Assignee: nobody → jsnajdr
Comment on attachment 8766301 [details] [diff] [review]
Requests cannot be sorted by cause

Review of attachment 8766301 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for quick patch, looks great to me, nothing I would change.
(the test passes for me on my machine)

The try looks also good.

Honza
Attachment #8766301 - Flags: review?(odvarko) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 5

2 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/3ab0235c289b
Requests cannot be sorted by cause r=Honza
Keywords: checkin-needed

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3ab0235c289b
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
I have reproduced this bug on Firefox nightly according to

Fixing bug is verified on Latest Nightly--Build ID:(20160711034039),User Agent: Mozilla/5.0 (Windows NT 10.0; rv:50.0) Gecko/20100101 Firefox/50.0


Tested OS--Windows10 32bit
QA Whiteboard: [bugday-20160713]

Updated

a month ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.