RESOLVED FIXED in Firefox 49

Status

()

Core
JavaScript Engine
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: birtles, Assigned: mrrrgn)

Tracking

({regression})

Trunk
mozilla50
regression
Points:
---

Firefox Tracking Flags

(firefox47 unaffected, firefox48 unaffected, firefox49 fixed, firefox50 fixed)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
See: https://github.com/webcompat/web-bugs/issues/2797

Loading the bug URL in Firefox 49 or later shows a page that gets stuck loading content. It says, ただいま地図を読み込み中です... ("Currently downloading map...").

In the console there is an unhandled exception which seems to be related to the AJAX request (based on the stack): "TypeError: str.match(...) is null"

mozregression points to bug 1266255 as the cause.

Loading the same URL in Chrome/Edge/Firefox 48 or less, displays the content as expected.
(Reporter)

Comment 1

2 years ago
Morgan, do you know what is happening here?
Flags: needinfo?(winter2718)
(Assignee)

Comment 2

2 years ago
I see the error, we're incorrectly deriving the function's name from it's display atom: ".Deferred/</i[o[0]]()" to "0]" when it should be "".
Flags: needinfo?(winter2718)
(Assignee)

Updated

2 years ago
Assignee: nobody → winter2718
(Assignee)

Comment 3

2 years ago
Created attachment 8765309 [details] [diff] [review]
displayname.diff

This is so ... yuck :( I'm going to see about ripping this entire "display name parsing" mechanism when I work on computed property names.
Attachment #8765309 - Flags: review?(jorendorff)
Comment on attachment 8765309 [details] [diff] [review]
displayname.diff

Review of attachment 8765309 [details] [diff] [review]:
-----------------------------------------------------------------

Ugh. Maybe it is time to throw away displayName.
Attachment #8765309 - Flags: review?(jorendorff) → review+

Comment 5

2 years ago
Pushed by mphillips@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b85f918f0db
Refuse to parse display names with unquoted, non-numeric, property names; r=jorendorff
(Assignee)

Comment 6

2 years ago
(In reply to Jason Orendorff [:jorendorff] from comment #4)
> Comment on attachment 8765309 [details] [diff] [review]
> displayname.diff
> 
> Review of attachment 8765309 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Ugh. Maybe it is time to throw away displayName.

Maybe I can do all of this with a new opcode: JSOP_SETFNAME (or something along those lines). If not, yes, I'll open a bug to get a dialogue started with devtools. It's a real thorn! <sub>ps, thx for the quick review. :]</sub>
(Assignee)

Comment 7

2 years ago
s/I/we/g

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9b85f918f0db
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
(Reporter)

Comment 9

2 years ago
Thanks for the quick fix! We'll want to uplift this to Aurora once it's baked on trunk.
(Reporter)

Comment 10

2 years ago
Hi Morgan, thanks for fixing this so quickly. Would you mind requesting aurora approval? Thanks!
Flags: needinfo?(winter2718)
(Assignee)

Comment 11

2 years ago
(In reply to Brian Birtles (:birtles) from comment #10)
> Hi Morgan, thanks for fixing this so quickly. Would you mind requesting
> aurora approval? Thanks!

Derp! Thanks for the reminder, and for reporting this! :)
Flags: needinfo?(winter2718)
(Assignee)

Comment 12

2 years ago
Comment on attachment 8765309 [details] [diff] [review]
displayname.diff

Approval Request Comment
[Feature/regressing bug #]: 1282332
[User impact if declined]: Broken web pages.
[Describe test coverage new/current, TreeHerder]: Tests are included with the patch.
[Risks and why]: Risks are minimal. The changes are isolated.
[String/UUID change made/needed]:
Attachment #8765309 - Flags: approval-mozilla-aurora?
Comment on attachment 8765309 [details] [diff] [review]
displayname.diff

Fix for regression from 49, includes tests, let's take it!
Attachment #8765309 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 14

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/b27163b500de
status-firefox49: affected → fixed
You need to log in before you can comment on or make changes to this bug.