1282344 - [Remote Control] After reboot TV, send tab will switch to previous remote control page but it cannot work

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect, P1)

Description

[Mike Lien[:mlien]]

[Testing Steps]
0. Paired Fennec and TV
1. Reboot TV
2. Send tab again from Fennec (will switch to previous remote control page)
3. Try to use remote control page

[Expected result]
Remote control page should work normally

[Actual result]
Remote control page cannot work

[Build Info]
Environment: 2.6 Nexus Player
gaia:
https://github.com/mozilla-b2g/gaia/commit/500eba02e3bf90099eb23864008f3f2ae3bb4947
gecko:
https://github.com/mozilla-b2g/gecko-b2g/commit/49b98aa3b415380cc7a021d740b242894654245a

Fennec add-on:
https://github.com/ChunMinChang/fennec-fxos-tv/commit/68e9f6c5f25f9664a2b8201a1f51e274e9849de7

Comment 1

[C.M.Chang[:chunmin] | PTO]

Hi Mike, 
I just update a patch. The add-on currently will kill the control page once the connection is closed. Therefore, this case won't exist anymore. Please help to test it, thanks!

https://github.com/ChunMinChang/fennec-fxos-tv/commit/907b25ba04102d8c70072c37eb79cd39772f43bd

Comment 2

[C.M.Chang[:chunmin] | PTO]

After verifying, the above patch can work on nexus 5 if we use power key to reboot/shutdown. However, nexus player doesn't have power key, so it can only be shutdown by unplugging, and the patch can't work on this case. The problem is that Fennec can't get the callback when the connection is dropper. What's worse is the |nsISocketTransport.isAlive()| returns true when the TV is already power-off. I open another bug to track this issue: Bug 1282390

Comment 3

[C.M.Chang[:chunmin] | PTO]

A workaround here is to use a dummy packet to test whether the connection is alive or not. 

Before sending a web page to TV, if Fennec think the connection with the server is alive, then send a dummy packet and wait for an ack. If there is no ack received in time, then Fennec will think the connection is closed and build a new connection to TV.

Comment 4

[Eric Tsai (no more review request accepted)]

Can I assume the connection is established and already in send command status when you want to test? If so, how about send a unused key code in key press event (like KeyboardEvent.DOM_VK_F24) for it?

Comment 5

[C.M.Chang[:chunmin] | PTO]

Hi Eric,
Yes, you can assume the connection status is already authenticated. 
I think if we use something like {type: 'check'} and {type: 'ack'} will be clearer for its purpose.

Comment 6

[Eric Tsai (no more review request accepted)]

How about {type: "ack", detail: "ping" (and "pong" from TV)}? This is only available as send command, so you can't send before JPAKE authentication.

Comment 7

[Eric Tsai (no more review request accepted)]

Attachment: Patch 1. Implement ping-pong for connection detection

Comment 8

[C.M.Chang[:chunmin] | PTO]

Comment on attachment 8765817 [details] [review]
Patch 1. Implement ping-pong for connection detection

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined:
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
[String changes made]:

Comment 9

[Josh Cheng [:josh]]

Comment on attachment 8765817 [details] [review]
Patch 1. Implement ping-pong for connection detection

Approve for TV 2.6

Comment 10

[Gary Chen [:xeonchen]]

https://github.com/mozilla-b2g/gecko-b2g/commit/d6ee2a76c14cfb6a3007b75d4ca2a7742d5edc5a