Closed
Bug 1282392
Opened 9 years ago
Closed 9 years ago
xbl bindings fail with unused "bindings" when no-unused-vars is enabled
Categories
(Developer Infrastructure :: Lint and Formatting, defect)
Tracking
(firefox50 fixed)
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: Fallen, Assigned: Fallen)
References
Details
Attachments
(1 file)
|
1.15 KB,
patch
|
miker
:
review+
|
Details | Diff | Splinter Review |
The generated code starts with |var bindings = {...| which causes no-unused-vars to fail. I proposed to change this to |this.bindings = {| which doesn't cause that message.
|
Assignee | |
Updated•9 years ago
|
Summary: xbl bindings fail with undefined "bindings" when no-unused-vars is enabled → xbl bindings fail with unused "bindings" when no-unused-vars is enabled
|
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8765401 -
Flags: review?(mratcliffe)
Attachment #8765401 -
Flags: review?(mratcliffe) → review+
|
|
Assignee | |
Comment 2•9 years ago
|
||
Thanks for the quick review!
Blocks: 1280898
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/4763e5023658
xbl bindings fail with unused "bindings" when no-unused-vars is enabled. r=miker
Keywords: checkin-needed
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
|
||
Updated•7 years ago
|
Product: Testing → Firefox Build System
|
||
Updated•7 years ago
|
Version: Version 3 → 3 Branch
|
|
||
Updated•3 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•