1282569 - handle requests that don't substitute %PRODUCT%, et. al.

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (backend), defect)

Description

[[e-mail] (:bhearsum)]

Apparently, we get tens of thousands of requests per day that don't substitute the URL variables. Eg:
[20/Jun/2016:01:14:50 +0000] "GET /update/4/%PRODUCT%/%VERSION%/%BUILD_ID%/%BUILD_TARGET%/%LOCALE%/%CHANNEL%/%OS_VERSION%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/%MOZ_VERSION%/update.xml HTTP/1.1" 400 226 "-" "Mozilla/5.0 (Android; Mobile; rv:37.0) Gecko/37.0 Firefox/37.0"

All of them appear to be Gecko 37.0 or 38.0. Makes me wonder if we busted the updater somehow around that time. In any case, I think it might be nice to add a route that quickly returns an empty response for these. There's no reason query the rules table - we'll never find anything useful in there.

Comment 1

[Amal Santhosh]

Hi, I'm new here :) I would like to work on this bug. Can you help my way around?

Comment 2

[[e-mail] (:bhearsum)]

(In reply to Amal Santhosh from comment #1)
> Hi, I'm new here :) I would like to work on this bug. Can you help my way
> around?

Hi Amal, thanks for your interest! The best first step for a bug like this is to ensure that you can run the Docker containers and tests locally. https://wiki.mozilla.org/Balrog#Hacking some instructions on that. Once you can successfully run "bash run-tests.sh", you should be ready to hack on this.

When you're ready to hack, the first step will be to write a new test in https://github.com/mozilla/balrog/blob/master/auslib/test/web/test_client.py that simulates a request like the one from comment #0. Once you've written that, and it's failing, you can try to fix the bug. This will most likely be in https://github.com/mozilla/balrog/blob/master/auslib/web/base.py and/or https://github.com/mozilla/balrog/blob/master/auslib/web/views/client.py.

Comment 3

[Amal Santhosh]

Thank you so much for the details. I'll try my best at this :)

Comment 4

[Amal Santhosh]

I've been trying to follow the instructions but some error or the other crops up every time. As a first time user here I feel I don't have the experience for this particular issue and i apologize and request you to reassign the bug to someone who can do justice to it.

Thank you for the patience .

Comment 5

[[e-mail] (:bhearsum)]

(In reply to Amal Santhosh from comment #4)
> I've been trying to follow the instructions but some error or the other
> crops up every time. As a first time user here I feel I don't have the
> experience for this particular issue and i apologize and request you to
> reassign the bug to someone who can do justice to it.
> 
> Thank you for the patience .

Sorry to hear that. If you still have them, could you e-mail me the errors you hit? It's something I'd like to improve in the future.

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/130852f322ad8a3bfd925c3dc37aa66ae5b3859c
bug 1282569: handle requests that don't substitute %PRODUCT%, et. al. (#161). r=bhearsum

Comment 7

[[e-mail] (:bhearsum)]

In production, thanks Njira!