1282588 - Handle failure when trying to join private rooms

Status: RESOLVED FIXED

(Chat Core :: XMPP, defect)

Description

[aleth [:aleth]]

<error xmlns="jabber:client" code="407" type="auth">
  <registration-required xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
</error>
xmpp.jsm:225

Maybe these are password-protected?

Comment 1

[Abdelrahman Ahmed [:abdelrahman]]

(In reply to aleth [:aleth] from comment #0)
> <error xmlns="jabber:client" code="407" type="auth">
>   <registration-required xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
> </error>
> xmpp.jsm:225
> 
> Maybe these are password-protected?

No, according to XEP-0045 (7.2.7 Members-Only Rooms)
> If the room is members-only but the user is not on the member list, the service
> MUST deny access to the room and inform the user that they are not allowed to
> enter the room

Comment 2

[Abdelrahman Ahmed [:abdelrahman]]

Attachment: v1 - Handle failure when trying to join members-only rooms

Comment 3

[aleth [:aleth]]

Comment on attachment 8765884 [details] [diff] [review]
v1 - Handle failure when trying to join members-only rooms

Review of attachment 8765884 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks

::: chat/protocols/xmpp/xmpp.jsm
@@ +207,5 @@
>        let message;
>        switch (error.condition) {
>          case "not-authorized":
> +        case "registration-required":
> +        // XEP-0045 (7.2.7): Members-Only Rooms.

Nit: indentation (please fix before checkin)

Comment 4

[Abdelrahman Ahmed [:abdelrahman]]

Nit fixed before checkin
https://hg.mozilla.org/comm-central/rev/e40c09063bdc