Closed Bug 1282588 Opened 4 years ago Closed 4 years ago

Handle failure when trying to join private rooms

Categories

(Chat Core :: XMPP, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Instantbird 50

People

(Reporter: aleth, Assigned: abdelrahman)

Details

Attachments

(1 file)

<error xmlns="jabber:client" code="407" type="auth">
  <registration-required xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
</error>
xmpp.jsm:225

Maybe these are password-protected?
(In reply to aleth [:aleth] from comment #0)
> <error xmlns="jabber:client" code="407" type="auth">
>   <registration-required xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
> </error>
> xmpp.jsm:225
> 
> Maybe these are password-protected?

No, according to XEP-0045 (7.2.7 Members-Only Rooms)
> If the room is members-only but the user is not on the member list, the service
> MUST deny access to the room and inform the user that they are not allowed to
> enter the room
Assignee: nobody → ab
Status: NEW → ASSIGNED
Comment on attachment 8765884 [details] [diff] [review]
v1 - Handle failure when trying to join members-only rooms

Review of attachment 8765884 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks

::: chat/protocols/xmpp/xmpp.jsm
@@ +207,5 @@
>        let message;
>        switch (error.condition) {
>          case "not-authorized":
> +        case "registration-required":
> +        // XEP-0045 (7.2.7): Members-Only Rooms.

Nit: indentation (please fix before checkin)
Attachment #8765884 - Flags: review?(aleth) → review+
Nit fixed before checkin
https://hg.mozilla.org/comm-central/rev/e40c09063bdc
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 50
You need to log in before you can comment on or make changes to this bug.