1282606 - Fix TrackingFlags and Bug object memory leaks

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Dylan Hardison [:dylan] (he/him)]

Under heavy usage, the bug modal edit API will cause web workers to run out of memory every 60 seconds. It's a good idea to fix the memory leak now.

Comment 1

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1282606_1.patch

This should fix much of the memory leaks. Running under mod_perl, you can run 'ab' against the bug modal API to test. -c 4 -n 1000 should result in frequent SizeLimit messages in the error log. With this patch applied, memory usage (for that API) should be nearly constant.

Comment 2

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1282606_2.patch

This removes the majority of memory leaks from BMO.

Comment 3

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1282606_3.patch

wrong patch. This one should work.

Comment 4

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1282606_4.patch

Comment 5

[David Lawrence [:dkl]]

Comment on attachment 8765972 [details] [diff] [review]
1282606_4.patch

Review of attachment 8765972 [details] [diff] [review]:
-----------------------------------------------------------------

mac-thor?

Fix comments on commit. r=dkl

::: Bugzilla/Comment.pm
@@ +241,5 @@
>  sub bug {
>      my $self = shift;
>      require Bugzilla::Bug;
> +    my $bug = $self->{bug} ||= new Bugzilla::Bug($self->bug_id);
> +    weaken($self->{bug});

need to import 'weaken' at the beginning of Comment.pm

::: extensions/TrackingFlags/Extension.pm
@@ +555,5 @@
> +sub request_cleanup {
> +    foreach my $flag (@FLAG_CACHE) {
> +        my $bug_flag = delete $flag->{bug_flag};
> +        if ($bug_flag) {
> +            my $bug = delete $bug_flag->{bug};

nit: no need to assign to $bug, just do delete $bug_flag->{bug};

Comment 6

[Dylan Hardison [:dylan] (he/him)]

To [e-mail]:mozilla-bteam/bmo.git
   3bf65ba..9a15297  master -> master