1282611 - Captive portal not detected at Firefox startup

Status: RESOLVED FIXED

(Firefox :: General, defect, P3)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

This was working when I was writing/testing the patch for bug 989193, but something seems to have broken before that landed.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Patch

This also changes the patch to use document-shown instead of xul-window-visible, which doesn't seem to work (anymore?) for detecting when the window gains focus. I'll investigate this further later, but meanwhile I wanted to upload this simple patch (having it work at startup makes it much easier to test some stuff).

Before requesting review however, I wanted to ask: Valentin, shouldn't nsIOService be doing a recheck at startup already? Doesn't seem to be working, could you take a look? If you can fix it from there this patch won't be necessary (though we should probably do the s/xul-window-visible/document-shown/g change in a separate bug).

Comment 2

[Valentin Gosu [:valentin] (he/him) {{ FYI: OOO 14 June - 4 August }}]

Detection would actually be triggered by the first network activity, so it's a bit racy.
You're correct in saying the we should probably do this more reliably, but I think your patch will do for now.

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Patch v2

Okay, we don't need to switch to document-shown. That confuses things further since each tab has its own document, etc.

A better fix (which this patch does) is to check that Services.ww.activeWindow is the same as whatever getMostRecentBrowserWindow returned. This works right after xul-window-visible, even if the window's document hasn't gotten focus yet.

Matt, what do you think?

Comment 4

[Matthew N. [:MattN]]

Sorry for the delay, but after coming back from PTO I'm dealing with another bug with high priority. I'll hopefully get to your reviews tomorrow.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/003319dc7a1f
Recheck for captive portal after watcher is initialized. r=MattN

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/003319dc7a1f