1282629 - An enhancement to make it easier to do windows build via task scheduler

Status: RESOLVED FIXED

(Firefox Build System :: MozillaBuild, task)

Description

[Bill Gianopoulos [:WG9s]]

I have been doing Windows builds via the task scheduler for a while now.  to make this work I am making a trivial mod to mozilla build start-msvc scripts.  It is kind of a pain to do this at each update to Mozilla build it would be nice if this (or something better) could be incorporated into the real builds.

Comment 1

[Bill Gianopoulos [:WG9s]]

The changes I made are in start-shell.bat to change the part at the end to:

cd "%USERPROFILE%"
IF "%USE_MINTTY%" == "1" (
  START %MOZILLABUILD%msys\bin\mintty -e %MOZILLABUILD%msys\bin\console %MOZILLABUILD%msys\bin\bash --login
) ELSE (
  IF "%*%" == "" (
    %MOZILLABUILD%msys\bin\bash --login -i
  ) ELSE (
    %MOZILLABUILD%msys\bin\bash --login -i -c "%*"
  )
)
EXIT /B

:_QUIT
ECHO MozillaBuild Install Directory: %MOZILLABUILD%
IF DEFINED VCDIR (ECHO Visual C++ %MOZ_MSVCYEAR% Directory: !VCDIR!)
IF DEFINED SDKDIR (ECHO Windows SDK Directory: !SDKDIR!)
IF DEFINED TOOLCHAIN (ECHO Trying to use the MSVC %MOZ_MSVCYEAR% !TOOLCHAIN! toolchain.)
ECHO.
ECHO %ERROR%
ECHO.
PAUSE
EXIT /B

and then to change each of the start-shell msvcxxx.bat to alter the:

CALL start-shell.bat

to be:

CALL start-shell.bat %*

This allows me to run things under the start-shell-msvcxxx.bat scripts to run a shell script.  Thus permitting me to run automated builds under the windows task scheduler.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Sure, why not. Given that start-shell-msvc*.bat no longer exist, can you confirm that the start-shell.bat changes by themselves are sufficient?

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Attachment: proposed patch

Bill's proposal in patch form.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Attachment: proposed patch

Accidentally removed a line I didn't mean to there.

Comment 6

[Bill Gianopoulos [:WG9s]]

The patch looks great to me!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-build/rev/4267e6be09d3
Allow start-shell.bat to send additional args to bash on startup. r=RyanVM