Support whole word search for find in page

VERIFIED FIXED in Firefox 64

Status

()

P3
normal
VERIFIED FIXED
2 years ago
22 days ago

People

(Reporter: mikedeboer, Assigned: Snuffleupagus)

Tracking

50 Branch
Firefox 64
Points:
---
Dependency tree / graph
Bug Flags:
firefox-backlog +

Firefox Tracking Flags

(firefox62 wontfix, firefox63 wontfix, firefox64 verified)

Details

(Whiteboard: [pdfjs-c-feature])

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Since bug 269442, the find toolbar support a new mode, called 'Whole Words', which only matches strings surrounded by word-breaking characters, like spaces or punctuation marks in latin-derived languages.

As you might know, this is the default matching mode for the find toolbars in Webkit/ Blink based browsers.

The implementation uses the term 'entireword', not 'wholeword' as you might think. This is due to historical reasons that are not very interesting for this bug ;-)
Flags: qe-verify+
Flags: firefox-backlog+

Updated

2 years ago
Priority: -- → P3
Whiteboard: [pdfjs-c-feature]
(Assignee)

Updated

8 months ago
Duplicate of this bug: 1448893
(Assignee)

Updated

5 months ago
Duplicate of this bug: 1471401
(Assignee)

Comment 3

2 months ago
Created attachment 9007160 [details] [diff] [review]
entireWord.patch
Assignee: nobody → jonas.jenwald
Attachment #9007160 - Flags: review?(bdahl)
(Assignee)

Updated

2 months ago
Keywords: leave-open
(Assignee)

Updated

2 months ago
Depends on: 1489996
Keywords: leave-open

Updated

2 months ago
Attachment #9007160 - Flags: review?(bdahl) → review+
(Assignee)

Updated

2 months ago
Keywords: checkin-needed

Comment 4

2 months ago
Pushed by dluca@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e6d4af6ebdd5
Include the `entireWord` mode when forwarding find events to the PDF.js viewer. r=bdahl
Keywords: checkin-needed

Comment 5

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e6d4af6ebdd5
Status: NEW → RESOLVED
Last Resolved: 2 months ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Hi Mike and Jonas,
Can one of you provide some steps to reproduce for this issue?
Thanks!
Flags: needinfo?(mdeboer)
Flags: needinfo?(jonas.jenwald)
status-firefox50: affected → ---
(Reporter)

Comment 7

28 days ago
Ah, I think Jonas should be the one to get you an STR here - if he's available, otherwise Brendan could. My guess here:
Open up a PDF document containing text, open up the find-in-page bar, toggle the 'While Words' option button and start trying to find whole words in the document.
The ER should be that only whole words can be found, not partial matches.
Flags: needinfo?(mdeboer) → needinfo?(bdahl)
I have reproduced the issue in Nightly v64.0a1 from 2018-09-05 and I have verified it in Nightly v64.0a1 from 2018-10-19.
I have also verified if it occurs in firefox63 and firefox62 and set the tags accordingly but considering that the target was set as Firefox 64, I have set the general status of this bug as VERIFIED.

The steps taken to verify the issue are the following:
1. Open the browser and reach: http://etd.lib.byu.edu/PDFCreation/EditingTextinPDFDocuments.pdf
2. Tap: "CTRL+F" to use the search in page feature;
3. Click the "Whole words" button from the find in page bar to activate this option.
4. Search for the word "you" and make sure that the word "your" is not highlighted as a result.
Affected: The word "your" is also highlighted as a result.
Fixed: The word "your" is not highlighted as a result.

Thank you.
Status: RESOLVED → VERIFIED
status-firefox62: --- → affected
status-firefox63: --- → affected
status-firefox64: fixed → verified
Flags: qe-verify+
status-firefox62: affected → wontfix
status-firefox63: affected → wontfix
(Assignee)

Updated

22 days ago
Flags: needinfo?(bdahl)
(Assignee)

Updated

22 days ago
Flags: needinfo?(jonas.jenwald)
You need to log in before you can comment on or make changes to this bug.