Closed Bug 1282792 Opened 4 years ago Closed 4 years ago

FF sends RTCP sender reports for recvonly tracks

Categories

(Core :: WebRTC: Signaling, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox47 --- unaffected
firefox48 --- unaffected
firefox49 --- fixed
firefox50 --- fixed
Blocking Flags:

People

(Reporter: drno, Assigned: drno)

References

Details

Attachments

(1 file)

Logging and network traces show that FF when using meet.jit.si starts to send RTCP sender reports although a recvonly m-section has been negotiated.
Attachment #8765922 - Flags: review?(docfaraday)
backlog: --- → webrtc/webaudio+
Attachment #8765922 - Flags: review?(docfaraday) → review+
Comment on attachment 8765922 [details]
Bug 1282792: start transmitting OR receiving if track is active

https://reviewboard.mozilla.org/r/61038/#review57874

Looks reasonable.
Pushed by drno@ohlmeier.org:
https://hg.mozilla.org/integration/autoland/rev/6eccb6aa19da
start transmitting OR receiving if track is active r=bwc
https://hg.mozilla.org/mozilla-central/rev/6eccb6aa19da
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Nils -- Since Fx 49 is affected, do you want to ask for uplift on this?
Flags: needinfo?(drno)
Comment on attachment 8765922 [details]
Bug 1282792: start transmitting OR receiving if track is active

Approval Request Comment
[Feature/regressing bug #]: Bug 1213773 introduced new code which only considered 1 of the 2 possible scenarios.
[User impact if declined]: In worst case as the RTCP reports from Firefox could get ignored by the sender and therefore the video and/or audio playback in a WebRTC call in Firefox could hang or stutter.
[Describe test coverage new/current, TreeHerder]: Just manual verification that Firefox no longer sends the wrong RTCP reports.
[Risks and why]: Not very high risk as the patch only calls a function which is called in lots of other places already, to properly set the correct internal status bits in the webrtc.org code.
[String/UUID change made/needed]: N/A
Flags: needinfo?(drno)
Attachment #8765922 - Flags: approval-mozilla-aurora?
Comment on attachment 8765922 [details]
Bug 1282792: start transmitting OR receiving if track is active

This patch fixes a potential hang issue. Take it in aurora.
Attachment #8765922 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.