1282792 - FF sends RTCP sender reports for recvonly tracks

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P1)

Description

[Nils Ohlmeier [:drno]]

Logging and network traces show that FF when using meet.jit.si starts to send RTCP sender reports although a recvonly m-section has been negotiated.

Comment 1

[Nils Ohlmeier [:drno]]

Attachment: Bug 1282792: start transmitting OR receiving if track is active

Review commit: https://reviewboard.mozilla.org/r/61038/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61038/

Comment 2

[Byron Campen [:bwc]]

Comment on attachment 8765922 [details]
Bug 1282792: start transmitting OR receiving if track is active

https://reviewboard.mozilla.org/r/61038/#review57874

Looks reasonable.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6eccb6aa19da
start transmitting OR receiving if track is active r=bwc

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6eccb6aa19da

Comment 5

[Maire Reavy [:mreavy]]

Nils -- Since Fx 49 is affected, do you want to ask for uplift on this?

Comment 6

[Nils Ohlmeier [:drno]]

Comment on attachment 8765922 [details]
Bug 1282792: start transmitting OR receiving if track is active

Approval Request Comment
[Feature/regressing bug #]: Bug 1213773 introduced new code which only considered 1 of the 2 possible scenarios.
[User impact if declined]: In worst case as the RTCP reports from Firefox could get ignored by the sender and therefore the video and/or audio playback in a WebRTC call in Firefox could hang or stutter.
[Describe test coverage new/current, TreeHerder]: Just manual verification that Firefox no longer sends the wrong RTCP reports.
[Risks and why]: Not very high risk as the patch only calls a function which is called in lots of other places already, to properly set the correct internal status bits in the webrtc.org code.
[String/UUID change made/needed]: N/A

Comment 7

[Gerry Chang [:gchang]]

Comment on attachment 8765922 [details]
Bug 1282792: start transmitting OR receiving if track is active

This patch fixes a potential hang issue. Take it in aurora.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/74d0f7c374dc