1282863 - Update / remove DevTools telemetry histograms expiring in 50

Status: RESOLVED FIXED

(DevTools :: General, defect, P2)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Here are the telemetry histograms expiring in 50:

* DEVTOOLS_DEBUGGER_RDP_LOCAL_LISTSERVICEWORKERREGISTRATIONS_MS expires in version 50.0a1 (watched by [e-mail], [e-mail]) - The time (in milliseconds) that it took a 'listServiceWorkerRegistrations' request to go round trip.
* DEVTOOLS_DEBUGGER_RDP_REMOTE_LISTSERVICEWORKERREGISTRATIONS_MS expires in version 50.0a1 (watched by [e-mail], [e-mail]) - The time (in milliseconds) that it took a 'listServiceWorkerRegistrations' request to go round trip.
* DEVTOOLS_SCRATCHPAD_WINDOW_OPENED_PER_USER_FLAG expires in version 50.0a1 (watched by [e-mail]) - Number of users that have opened the DevTools Scratchpad standalone window.
* DEVTOOLS_SCRATCHPAD_WINDOW_TIME_ACTIVE_SECONDS expires in version 50.0a1 (watched by [e-mail]) - How long has Scratchpad standalone window been active (seconds)

We should decide what to do with each one.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

AFAIK, all of the DEVTOOLS_DEBUGGER_RDP_*_MS histograms are added habitually following a pattern over the course of many years.  I am not aware of a case where we've used this data over the past several years that we've had it.

I would recommend that we remove the RDP telemetry feature in the client and remove all DEVTOOLS_DEBUGGER_RDP_*_MS histograms.

:ejpbruel and :fitzgen have added most of these histograms over the years.  Do either of you see a use for this data, or does it seem fine to remove the histograms?

Comment 2

[Eddy Bruel [:ejpbruel]]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #1)
> AFAIK, all of the DEVTOOLS_DEBUGGER_RDP_*_MS histograms are added habitually
> following a pattern over the course of many years.  I am not aware of a case
> where we've used this data over the past several years that we've had it.
> 
> I would recommend that we remove the RDP telemetry feature in the client and
> remove all DEVTOOLS_DEBUGGER_RDP_*_MS histograms.
> 
> :ejpbruel and :fitzgen have added most of these histograms over the years. 
> Do either of you see a use for this data, or does it seem fine to remove the
> histograms?

I have no need for these histograms personally.

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

I'm fine with this removal. We've added new telemetry probes that more explicitly test the things I used to use some of these probes for.

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

:clarkbw, in the mailing list you mentioned DEVTOOLS_SCRATCHPAD_WINDOW_OPENED_PER_USER_FLAG should be removed.  There is also bug 1250171 comment 11 where we decided to eventually remove all *_OPENED_PER_USER_FLAG histograms.  Is it time to proceed with that work, or are we waiting on something?

For DEVTOOLS_SCRATCHPAD_WINDOW_TIME_ACTIVE_SECONDS, it seems like you do use metrics of this kind on your site, but this particular histogram is not used currently.  Should we extend the lifetime?  (Do you intend to investigate Scratchpad usage?)

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I filed bug 1282900 to remove the debugger RDP probes.

Comment 6

[Bryan Clark (DevTools PM) [:clarkbw]]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #4)
> :clarkbw, in the mailing list you mentioned
> DEVTOOLS_SCRATCHPAD_WINDOW_OPENED_PER_USER_FLAG should be removed.  There is
> also bug 1250171 comment 11 where we decided to eventually remove all
> *_OPENED_PER_USER_FLAG histograms.  Is it time to proceed with that work, or
> are we waiting on something?
> 
> For DEVTOOLS_SCRATCHPAD_WINDOW_TIME_ACTIVE_SECONDS, it seems like you do use
> metrics of this kind on your site, but this particular histogram is not used
> currently.  Should we extend the lifetime?  (Do you intend to investigate
> Scratchpad usage?)

Definitely all the *_OPENED_PER_USER_FLAG probes are fragile and should be deprecated now that we can achieve much better longitudinal queries in other ways if there is also a *_COUNT probe type.

I do use some of the *_WINDOW_TIME_ACTIVE_SECONDS values.  However I don't use or intend to use the Scratchpad usage numbers; so as far as I'm concerned they could be removed.  I could possibly be convinced otherwise but at the point I don't think the numbers for Scratchpad justify further investment of development.

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

The *_PER_USER_FLAG probes were removed in bug 1250171.

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1282863 - Remove DEVTOOLS_SCRATCHPAD_WINDOW_TIME_ACTIVE_SECONDS probe.

Review commit: https://reviewboard.mozilla.org/r/74680/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/74680/

Comment 9

[Bryan Clark (DevTools PM) [:clarkbw]]

I haven't forgotten about this, I was just trying to run a couple queries on re:dash to make sure I'm not wrong about the scratchpad.  The opened count numbers are much higher compared to the shader, webaudio, and canvas panels; much higher.

Comment 10

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Bryan Clark (DevTools PM) [:clarkbw] (out until Jan 2nd) from comment #9)
> I haven't forgotten about this, I was just trying to run a couple queries on
> re:dash to make sure I'm not wrong about the scratchpad.  The opened count
> numbers are much higher compared to the shader, webaudio, and canvas panels;
> much higher.

This seems pretty surprising!  Have you learned any more about this?

Comment 11

[Bryan Clark (DevTools PM) [:clarkbw]]

The scratchpad window numbers were more than expected, however I don't need them anymore.  I don't have questions I believe those numbers can answer.

Comment 12

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8786004 [details]
Bug 1282863 - Remove DEVTOOLS_SCRATCHPAD_WINDOW_TIME_ACTIVE_SECONDS probe.

https://reviewboard.mozilla.org/r/74680/#review103916

I believe :clarkbw's comment 11 counts as r+ to remove the scracthpad window probe here.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f1521957c98
Remove DEVTOOLS_SCRATCHPAD_WINDOW_TIME_ACTIVE_SECONDS probe. r=jryans

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1f1521957c98

Comment 15

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 8786004 [details]
Bug 1282863 - Remove DEVTOOLS_SCRATCHPAD_WINDOW_TIME_ACTIVE_SECONDS probe.

https://reviewboard.mozilla.org/r/74680/#review105722