Closed Bug 1282906 Opened 5 years ago Closed 5 years ago

Fix a few issues in the schedule TC jobs patch

Categories

(Tree Management :: Treeherder, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: martianwars, Assigned: martianwars, Mentored)

References

Details

Attachments

(1 file)

This is a follow up to https://bugzilla.mozilla.org/show_bug.cgi?id=1254325
emorley has added a few nits to https://github.com/mozilla/treeherder/pull/1490
Let's address them!
Assignee: nobody → kalpeshk2011
Mentor: emorley, cdawson
Depends on: 1254325
Attachment #8766559 - Flags: feedback+
Comment on attachment 8766559 [details] [review]
[treeherder] martiansideofthemoon:fireandblood > mozilla:master

I have just made the changes, but not tested it completely. Will do it before the final review.
I wanted to refactor the decisionTaskID variable name to decision_task_id in the python files and pulse message. Could I file a new bug and mark it as simple for new contributors?
Flags: needinfo?(emorley)
Attachment #8766559 - Flags: feedback+ → feedback?(emorley)
Cancelling needinfo since it's not needed when other flags are set :-)
Flags: needinfo?(emorley)
Comment on attachment 8766559 [details] [review]
[treeherder] martiansideofthemoon:fireandblood > mozilla:master

I hope it is good.
Attachment #8766559 - Flags: feedback?(emorley) → review?(emorley)
Comment on attachment 8766559 [details] [review]
[treeherder] martiansideofthemoon:fireandblood > mozilla:master

Have left some comments. Almost there! :-)
Attachment #8766559 - Flags: review?(emorley) → feedback+
Comment on attachment 8766559 [details] [review]
[treeherder] martiansideofthemoon:fireandblood > mozilla:master

I hope it's better now :)
Attachment #8766559 - Flags: review?(emorley)
Comment on attachment 8766559 [details] [review]
[treeherder] martiansideofthemoon:fireandblood > mozilla:master

There are a couple of review comments left from the previous review. Once they're fixed, re-request review and we should be good to go :-)
Attachment #8766559 - Flags: review?(emorley) → review-
Attachment #8766559 - Flags: review- → review?(emorley)
Attachment #8766559 - Flags: review?(emorley) → review+
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Blocks: 1286897
You need to log in before you can comment on or make changes to this bug.