1282961 - Top tabs are incorrectly scrolled when switching between private mode on/off

Status: VERIFIED FIXED

(Firefox for iOS :: Browser, defect)

Description

[Nathanael Alcock]

Attachment: Incorrect tab positioning

Device iPad 2 Air

1. Add 2 normal tabs using the "+" button.
2. Switch to private browsing.
3. Add 5 private tabs using the "+" button.
4. Switch to normal browsing.

Actual result: the last normal tab is shown in the first position, with the first tab inaccessible.

Expected result: the tabs are shown in the position in which they were left, and all accessible.

5. Switch to private browsing.

Actual result: the last tab (that was previously selected) is not completely visible.

Expected result: the tabs are shown in the position in which they were left (the selected tab is completely visible).

Comment 1

[Tyler Lacroix [:tlacroix]]

Attachment: https://github.com/mozilla/firefox-ios/pull/1979

Comment 2

[Nathanael Alcock]

This seems to fix the incorrect positioning. There is a brief but noticeable animation when switching between the two modes, despite animating with a duration of zero. Is this something that could be addressed too?

Comment 3

[Stephan Leroux [:sleroux]]

Comment on attachment 8766867 [details] [review]
https://github.com/mozilla/firefox-ios/pull/1979

Comments/nits on the PR. Also found out why you're seeing that delay when transitioning between modes.

Comment 4

[Tyler Lacroix [:tlacroix]]

I fixed the animation bug. Do you mind rechecking Nathanael?

Comment 5

[Nathanael Alcock]

Looks much better now — that seems to do the trick!

Comment 6

[Stephan Leroux [:sleroux]]

master 82e3e773ab5aa21ffa7ca2208a945d1c4db1e8bc

Comment 7

[Simon Basca [:SimonB]]

Tested on iPad Air 2(10.0.2).

Verifying as fix on master 0e03028ac.